From 3f0674a6e21d71f374ad424e16d41475737636a8 Mon Sep 17 00:00:00 2001
From: Ken Wenzel <ken.wenzel@iwu.fraunhofer.de>
Date: Tue, 5 Nov 2024 15:03:32 +0100
Subject: [PATCH] Close response in AasClient.

---
 .../linkedfactory/core/rdf4j/aas/AasClient.java   | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/bundles/io.github.linkedfactory.core/src/main/java/io/github/linkedfactory/core/rdf4j/aas/AasClient.java b/bundles/io.github.linkedfactory.core/src/main/java/io/github/linkedfactory/core/rdf4j/aas/AasClient.java
index abaea49..44d5ac2 100644
--- a/bundles/io.github.linkedfactory.core/src/main/java/io/github/linkedfactory/core/rdf4j/aas/AasClient.java
+++ b/bundles/io.github.linkedfactory.core/src/main/java/io/github/linkedfactory/core/rdf4j/aas/AasClient.java
@@ -10,11 +10,12 @@
 import net.enilink.komma.core.URIs;
 import net.enilink.vocab.rdf.RDF;
 import org.apache.http.HttpEntity;
-import org.apache.http.HttpResponse;
 import org.apache.http.client.methods.HttpGet;
 import org.apache.http.client.utils.URIBuilder;
 import org.apache.http.impl.client.CloseableHttpClient;
 import org.apache.http.impl.client.HttpClients;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.Closeable;
 import java.io.IOException;
@@ -27,6 +28,8 @@
 import java.util.function.Supplier;
 
 public class AasClient implements Closeable {
+	private static Logger logger = LoggerFactory.getLogger(AasClient.class);
+
 	final String endpoint;
 	ObjectMapper mapper = new ObjectMapper();
 	CloseableHttpClient httpClient;
@@ -73,7 +76,7 @@ protected IExtendedIterator<Record> query(String endpoint, String path, Map<Stri
 
 		// sending get request to the endpoint
 		HttpGet httpGet = createHttpGet(getRequestUri.toString());
-		HttpResponse response = this.httpClient.execute(httpGet);
+		var response = this.httpClient.execute(httpGet);
 		HttpEntity entity = response.getEntity();
 		try (InputStream content = entity.getContent()) {
 			if (response.getStatusLine().getStatusCode() != 200) {
@@ -103,6 +106,14 @@ protected IExtendedIterator<Record> query(String endpoint, String path, Map<Stri
 			} else {
 				return WrappedIterator.create(Collections.singleton((Record) nodeToValue(node)).iterator());
 			}
+		} finally {
+			if (response != null) {
+				try {
+					response.close();
+				} catch (IOException ioe) {
+					logger.error("Error while closing response", ioe);
+				}
+			}
 		}
 	}