Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalized Url Detected http://null/ #1

Open
vshlos opened this issue Jun 25, 2015 · 2 comments
Open

Normalized Url Detected http://null/ #1

vshlos opened this issue Jun 25, 2015 · 2 comments

Comments

@vshlos
Copy link

vshlos commented Jun 25, 2015

Detecting the following url

www.foo1111111111aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.com
  • works ok for normal UrlDetector
  • fails when calling NormalizedUrl.create and returns it as "http://null/
@pgalbraith
Copy link

Per RFC 1034 this isn't a valid domain name (the second label is much larger than the 63-octet maximum allowed) so it cannot be normalized.

@vshlos
Copy link
Author

vshlos commented Oct 2, 2018

From what I remember - I think the goal is consistency. It should probably fail equally for both then. (if it isn't by consistent now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vshlos @pgalbraith