Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disconnect handling for use with manually set WebSocket endpoints #87

Closed
chaosharmonic opened this issue Sep 21, 2024 · 0 comments · Fixed by #94
Closed

Add disconnect handling for use with manually set WebSocket endpoints #87

chaosharmonic opened this issue Sep 21, 2024 · 0 comments · Fixed by #94
Labels
enhancement New feature or request

Comments

@chaosharmonic
Copy link
Contributor

When connecting to an existing browser session using launch, calling browser.close() kills the entire process. Calling launch with using also kills the whole process at the end.

Manually set WebSocket endpoints could maybe benefit from an explicit disconnect handler to close the connection and not the entire browser.

@lino-levan lino-levan added the enhancement New feature or request label Sep 23, 2024
@lino-levan lino-levan linked a pull request Oct 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants