Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate non-inclusive language #155

Closed
nhosoi opened this issue Dec 20, 2022 · 3 comments
Closed

Eliminate non-inclusive language #155

nhosoi opened this issue Dec 20, 2022 · 3 comments

Comments

@nhosoi
Copy link
Contributor

nhosoi commented Dec 20, 2022

Hello, we have a project to eliminate non-inclusive language from Linux-system-roles.

Running a utility woke (now it's supported in tox. please install the latest tox-lsr and run tox -e woke), two non-inclusive words are reported - sanity and master.

The word sanity is easily eliminated, but master is not since it's tightly coupled with the SQL context, e.g., as master key.

There are two ways to skip the check - adding wokeignore:rule=master to each master appearing in the source code, or skipping them as warning by applying get-woke/woke#252. Which way should we go or could there be some other ideas to workaround master?

@spetrosi
Copy link
Collaborator

spetrosi commented Jan 2, 2023

There are too many uses of master in the code. Running woke with --count-only-error-for-failure results in a success, so it's only the word master that matters. And the role cannot fix master in the SQL Server context. The role can only fix the use of master in unrelated context, e.g. rename the GitHub branch master > main.

@nhosoi
Copy link
Contributor Author

nhosoi commented Jan 4, 2023

Thank you for your comments, @spetrosi! Your proposal makes sense.

First, may I ask you to rename the master branch to the main branch as described in https://issues.redhat.com/browse/RHELPLAN-134435 by @richm.

Then, we can reduce the number of the word master before applying the --count-only-error-for-failure change. Thanks!

@nhosoi
Copy link
Contributor Author

nhosoi commented Jan 26, 2023

Thank you for merging #158, @spetrosi.
Closing this issue.

@nhosoi nhosoi closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants