Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly document how to register to Red Hat #142

Open
myllynen opened this issue Oct 12, 2023 · 5 comments
Open

Explicitly document how to register to Red Hat #142

myllynen opened this issue Oct 12, 2023 · 5 comments

Comments

@myllynen
Copy link

The documentation at https://github.com/linux-system-roles/rhc discusses about rhc_server but doesn't give any indication what if any values should be used when connecting to Red Hat instead of a local satellite. While many might guess or test that the variable can be left undefined it'd be better to avoid guessing and mention that explicitly. Thanks.

@ptoscano
Copy link
Collaborator

The general RHEL documentation for the role is here:
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9/html-single/automating_system_administration_by_using_rhel_system_roles/index#using-the-rhc-system-role-to-register-the-system_automating-system-administration-by-using-rhel-system-roles

For connecting to Red Hat, there are no attributes (e.g. rhc_server) to be changed by default; this is the same as invoking subscription-manager or rhc manually, which register to Red Hat by default OOTB.

While many might guess or test that the variable can be left undefined it'd be better to avoid guessing and mention that explicitly.

I'm not sure I understand the problem here: why would you need to guess? What's the "thought process" here that might lead to confusion?

@myllynen
Copy link
Author

I want to use this role to connect a system to Red Hat, not local Satellite. This is the role documentation: https://github.com/linux-system-roles/rhc. It doesn't tell what should values should be used for rhc_server in that case.

@ptoscano
Copy link
Collaborator

Just like the RHEL documentation does not mention any changes needed to register to Red Hat, the same applies here to the role.

What I can write is that not changing a/any parameter means that the "default" of the system, which means the underlying tool.

@myllynen
Copy link
Author

I think it would be a good idea to document the default, just like the default is documented with other variables as well. Thanks.

@richm
Copy link
Contributor

richm commented Oct 12, 2023

The role should explicitly state something like "To register to Red Hat, the rhc_server parameter should be omitted (or empty?)"
and we should have an example (if we do not already) of registering a system to Red Hat

- name: Register system to Red Hat
  vars:
    rhc:
      ....
  roles:
    - linux-system-roles.rhc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants