Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate non-inclusive language #59

Closed
nhosoi opened this issue Dec 21, 2022 · 4 comments
Closed

Eliminate non-inclusive language #59

nhosoi opened this issue Dec 21, 2022 · 4 comments

Comments

@nhosoi
Copy link
Contributor

nhosoi commented Dec 21, 2022

Hello, we have a project to eliminate non-inclusive language from the linux-system-roles.

Running a utility woke (now it's supported in tox. please install the latest tox-lsr and run tox -e woke), two non-inclusive words are reported - sanity and master.

The difficulty is ControlMaster is a configuration keyword for ssh. So, unless it's renamed in ssh, there is no way to avoid it in the ssh role. To skip the checking, there are two ways - adding wokeignore:rule=master to each ControlMaster appearing in the source code, or skipping them as warning by applying get-woke/woke#252. Which way is preferable?

@nhosoi
Copy link
Contributor Author

nhosoi commented Dec 21, 2022

Output from tox -e woke

@nhosoi
Copy link
Contributor Author

nhosoi commented Dec 23, 2022

I have one more question. I'd like to apply this similar changes to sshd, as well. The following is the diff (or my pull request candidate). May I open a pr for ansible-sshd?
willshersystems/ansible-sshd@master...nhosoi:ansible-sshd:woke-action
Thanks!

@nhosoi
Copy link
Contributor Author

nhosoi commented Jan 16, 2023

I've opened #64.
@Jakuje, @richm, could you please take a look? Thanks!

@nhosoi
Copy link
Contributor Author

nhosoi commented Jan 27, 2023

As #64 is merged, closing this issue.

@nhosoi nhosoi closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant