Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't re-order speakers when there is more than one row #929

Closed
cjyabraham opened this issue Aug 9, 2024 · 2 comments
Closed

Can't re-order speakers when there is more than one row #929

cjyabraham opened this issue Aug 9, 2024 · 2 comments
Assignees

Comments

@cjyabraham
Copy link
Collaborator

Re-ordering speakers in the editor by dragging-dropping doesn't seem to work well. When there are multiple rows of speakers it always wants to position the dragged item in the first row.

@cjyabraham cjyabraham moved this to Soon in lfevents Aug 9, 2024
@cjyabraham
Copy link
Collaborator Author

I looked into this a bit. It seems like the package we are using for drag-n-drop react-beautiful-dnd is no longer supported and has an open issue about sorting multi-row lists. People are recommending react-sortable-hoc instead. The react-select component we are using also recommends using react-sortable-hoc and has some sample code here.

So I suggest we swap out react-beautiful-dnd for react-sortable-hoc.

@cjyabraham cjyabraham assigned thetwopct and cjyabraham and unassigned thetwopct Aug 10, 2024
@cjyabraham cjyabraham moved this from Soon to In progress in lfevents Aug 14, 2024
cjyabraham added a commit that referenced this issue Aug 15, 2024
@cjyabraham
Copy link
Collaborator Author

cjyabraham commented Aug 15, 2024

It turns out react-sortable-hoc is also no longer supported so we went with dnd-kit in the end. Instructions for how to integrate dnd-kit with react-select are in this PR with code example.

@cjyabraham cjyabraham mentioned this issue Aug 15, 2024
2 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in lfevents Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants