Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weather@mockturtl : some french translations are now in english #3555

Closed
InfoLibre opened this issue Feb 13, 2021 · 16 comments
Closed

weather@mockturtl : some french translations are now in english #3555

InfoLibre opened this issue Feb 13, 2021 · 16 comments

Comments

@InfoLibre
Copy link
Contributor

InfoLibre commented Feb 13, 2021

 * Applet version 3.0.2
 * Cinnamon version 4.8.6
 * Mint 20.1

Notify author of applet
@mockturtl

Issue

In the French version, these comments are in English (it was in French in the previous version :

a

Capture d’écran du 2021-02-14 10-55-16

In the french version, a title and a part of the help is in English (it was in French in the previous version) and there was more comments in the previous version (they disappeared) :

Capture d’écran du 2021-02-13 12-34-38

This comment appears twice :

Capture d’écran du 2021-02-14 10-38-51

@jorgenqv
Copy link
Contributor

There have been some changes in the original English texts (and more is coming), so the French translation needs to be updated.

@InfoLibre
Copy link
Contributor Author

That's the problem with the .po files. The key for each entry is the English text and each time you modify it, all the other translations don't appear any more. Isn't it possible to use .po files with a number as key or something like that ?

@Gr3q
Copy link
Contributor

Gr3q commented Feb 13, 2021

What would happen if the original text is changed for a translation key? Still show the outdated translation? I don't see that as a better option

@InfoLibre
Copy link
Contributor Author

It's better to show the outdated translation than nothing. But indeed, we will not know when the translation must be updated. Another alert mechanism is necessary in this case, doesn't it exist ?

@jorgenqv
Copy link
Contributor

I am now aware of any alerts but there is almost always something changed in new versions? To check When donw I usually test my translation locally before committing it (see about .MO file below) if you mean when working with it? Here is how I do a translation most of the time (there is sure better ways of doing this?) posted in the Spices comment section five moths ago:

Localization and Translation Guide

  • Install package Poedit and choose a text editor that can compare files.
    One good alternative is jEdit with the visual diff and merge plugin jDiffPlugin installed.
  • Go to the Github website and browse to:
    cinnamon-spices-applets/weather@mockturtl/files/weather@mockturtl/po/
  • Download your language .PO file and the latest .POT template file.
  • Open the files side by side and compare, start working on your translation. Reuse previously contributed translations as much as possible and get familiar with the correct technical terms for things in your language.
  • When done open your .PO file in Poedit and go over all your translations again checking things look correct, there is usually always typos and other mistakes.
  • In Poedit click Verify and when everything is ok click on Save. This will generate a .MO file.
  • Now it’s time to test you translation in action. Copy the generated .MO file to ~/.local/share/locale/xx/LC_MESSAGES with the right file name and don’t forget to do a backup of the old [email protected] file.
  • Restart your computer and check that everything is working and looks like you want.
  • Finally edit the first rows of the .PO file, add the version number last on the row Project-Id-Version, add your name and email on the Last-Translator row, also creds and other useful information on the first hashtag marked rows is nice to have.

Please correct me if something can be done better :)

@Gr3q
Copy link
Contributor

Gr3q commented Feb 13, 2021

I just use Poedit to edit translations, it can update a .po file from a .pot file, look it up in your package manager.

To test it, you can clone this repo, edit the .po files there then run ./cinnamon-spices-makepot weather@mockturtl --install to install the edited translations for you. I always restart cinnamon after, I don't know if it's necessary.

There is no notification system as far as I know, but I'm more than happy to tag anyone - who is working on the translations and if they ask me - in my release PRs where I changed translations. I'm happy to even hold off a release if they feel it's important to release the new translations at the same time.

@InfoLibre
Copy link
Contributor Author

InfoLibre commented Feb 13, 2021

I tried to update the English texts in the French .po file, with the English text which is in the .pot file but I am not successful and I'm afraid to make a mistake. Could you update the fr.po file with the same English text as in the .pot file? Afterwards, I will be able to do the last translations in French.

@Gr3q
Copy link
Contributor

Gr3q commented Feb 13, 2021

Yeah you can, but it's easier if you use a tool like poedit to do that

@InfoLibre
Copy link
Contributor Author

InfoLibre commented Feb 13, 2021

Yes, I'm using poedit to update the french .po file but this file is buggy because the English text is not synchronized with the .pot file. Could you update the French .po file with the updated English text that is in the .pot file ?

@Gr3q
Copy link
Contributor

Gr3q commented Feb 13, 2021

Yes, I don't know off the top of my head but there is an option in one of the submenus called 'Update from .pot file'. Your can do it with that

@InfoLibre
Copy link
Contributor Author

I did and nothing happens.

@Gr3q
Copy link
Contributor

Gr3q commented Feb 13, 2021

Assuming you updated your branch with the latest upstream master, it updated it. The changes should be highlighted. ( In orange)

@French77
Copy link
Contributor

Yes, I'm using poedit to update the french .po file but this file is buggy because the English text is not synchronized with the .pot file. Could you update the French .po file with the updated English text that is in the .pot file ?

Update from POT file syncronized <->fr.po

Pot po bestanden

@InfoLibre
Copy link
Contributor Author

I did it ! Thank you for your help, I will propose a new translation .po file.

@jorgenqv
Copy link
Contributor

Thank you for the hints on how to use poedit, will check it out :)

@NikoKrause
Copy link
Member

This might help keeping track of new translatable strings:
#3588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants