Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up how payment instruments are updated #312

Open
rgalanakis opened this issue Nov 28, 2022 · 0 comments
Open

Clean up how payment instruments are updated #312

rgalanakis opened this issue Nov 28, 2022 · 0 comments
Labels
bug Something isn't working
Milestone
Purgatory

Comments

@rgalanakis
Copy link
Member

The current_member_header isn't a good solution since it includes payment instruments, which can be very large.

Instead, we should be adding it to the entity we render, so it's in the body.

Also make sure we are using a consistent update mechanism, instead of using setUser adhoc in various API calls. It should just be .then(handleUpdateCurrentMember).
@rgalanakis rgalanakis added the bug Something isn't working label Nov 28, 2022
@rgalanakis rgalanakis added this to the Food Pilot Release 2 milestone Nov 28, 2022
@rgalanakis rgalanakis self-assigned this Nov 28, 2022
rgalanakis added a commit that referenced this issue Nov 28, 2022
@rgalanakis
Must useMemo in contexts
669c56a 
The `value` was changing, causing massive re-renders.
Have to `useMemo` to avoid them in most cases.

Also clean up some payment instrument handlers in adding a card.
Will clean up the rest as part of
#312
@rgalanakis rgalanakis mentioned this issue Nov 28, 2022
Merged
@rgalanakis rgalanakis removed their assignment Dec 5, 2022
@rgalanakis rgalanakis modified the milestones: Food Pilot Release 3, Food Pilot Release 4, Food Pilot Release 5 Dec 12, 2022
@rgalanakis rgalanakis modified the milestones: Food Pilot Release 5, Purgatory Jan 9, 2023
@DeeTheDev DeeTheDev mentioned this issue Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Purgatory
Development

Successfully merging a pull request may close this issue.

Refactor how payment instruments are updated lithictech/suma
1 participant
@rgalanakis