Log participant updates. #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some missed subscriptions by services using this SDK. Seems to happen when a participant joins/leaves/rejoins in very quick succession. Logging participant updates (or other minor clean up) to understand this better.
paulwe
approved these changes
Jan 10, 2025
davidzhao
approved these changes
Jan 10, 2025
boks1971
added a commit
that referenced
this pull request
Feb 16, 2025
Had added log of participant update in #591 to debug missed subscriptions. Removing it as it was an issue on server due to one second resolution timestamps missing an update when a participant left and re-joined instantly.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some missed subscriptions by services using this SDK. Seems to happen when a participant joins/leaves/rejoins in very quick succession.
Logging participant updates (or other minor clean up) to understand this better.