Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fields to Fetch and Add Content to BookItemBack #8

Open
3 tasks
livoszlak opened this issue Oct 5, 2024 · 3 comments
Open
3 tasks

Add Fields to Fetch and Add Content to BookItemBack #8

livoszlak opened this issue Oct 5, 2024 · 3 comments

Comments

@livoszlak
Copy link
Owner

In the bare-bones fetch of useFetchBooks there are many fields that are not used in the frontend. For example, categories, pageCount, description, et c. The BookItemBack is obviously a small surface to display all of that on - but maybe you have a good solution for it?

Suggestions:

  • 1. Move title and author/-s to BookItem - but please make sure both will fit above or beneath cover image, in a way that doesn't mess with the styling cohesion. Title and author/-s should have the same space on every BookItem card, and cover image should also maintain consistent space on the card. In v1 of this project, I solved the issue of different lengths of titles and author names with having them "disappear" under ellipses, but perhaps you have a better solution?
  • 2. Having moved title and author from the back view of the card, display Page count and categories there instead. And perhaps description can appear in an additional BookItemBack component if user clicks a "See description"-button? Check out Nested modal - is it possible to have the child modal appear next to the parent modal? Side by side, sliding in from right? Let's find out!
  • 3. If "See description" child modal is implemented, perhaps replace the link icon on the back view of the parent modal with a "View on Google Books" button?
@om9090
Copy link
Contributor

om9090 commented Oct 5, 2024

@livoszlak Please assign the issue to me.

I understood all the changes proposed by you. I would love to contribute in your project. I have experience of over 1.5 years in Frontend Development I can defiinitely solve your issue. I will make the website more interactive and will enhace the UI and UX.

Thank you.

@livoszlak
Copy link
Owner Author

@om9090 Absolutely! Thank you for wanting to contribute. Assigning this issue to you right now! 🌷

@om9090
Copy link
Contributor

om9090 commented Oct 6, 2024

Thank you so much. I’ll start working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants