-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests that break under make test-network
#131
Comments
#133 fixes these tests:
Checking them off the list |
@llimllib The weather plugin is difficult to test due to the API key requirement. Any ideas on how we can handle that one? |
I forget what test system limbo uses, but could you set it to look for an
environment variable to get the API key, and if not set skip it?
…On Sat, 14 Oct. 2017, 7:57 am Topher Brown, ***@***.***> wrote:
@llimllib <https://github.com/llimllib> The weather plugin is difficult
to test due to the API key requirement. Any ideas on how we can handle that
one?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#131 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGk_7Y6Nmy5dsdzyEZbTmK0AxCC6VwhYks5sr9zUgaJpZM4P3-K4>
.
|
to test the API, you'll need an API key; but this is one place where it gets a bit weird, because you're basically at this point testing the weather API. Anyway, my advice is to get an API key and set it in the environment in which |
@StewPoll do you want a contributor bit too? Anything you want to work on? Also if either of you want an invite to the slack instance I use for testing, send me an email at |
#123 adds the command
make test-network
. These tests break under this new command:#122 fixes the stockphoto test, marking that as done
The text was updated successfully, but these errors were encountered: