Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Build issue on Windows #66

Open
aaronhagopian opened this issue Dec 17, 2015 · 4 comments
Open

Build issue on Windows #66

aaronhagopian opened this issue Dec 17, 2015 · 4 comments
Labels
Milestone

Comments

@aaronhagopian
Copy link

When trying to build I am getting the following error:

Downloading electron-v$npm_package_electronVersion-linux-ia32.zip
Error: GET https://github.com/atom/electron/releases/download/v$npm_package_electronVersion/electron-v$npm_package_electronVersion-linux-ia32.zip returned 404
[ [Error: GET https://github.com/atom/electron/releases/download/v$npm_package_electronVersion/electron-v$npm_package_electronVersion-linux-ia32.zip returned 404] ] undefined

seems like the $npm_package_electronVersion variable is not getting set correctly, ideas?

Thanks

@LongLiveCHIEF
Copy link
Contributor

Something with windows doesn't consume these the correct way. We're working on it for the full 1.3 release.

@LongLiveCHIEF LongLiveCHIEF modified the milestone: v1.3 Dec 30, 2015
@geekytime
Copy link
Collaborator

Yeah, I have the same issue. It seems to have something to do with how cmd.exe/git bash/npm work together to layer environment variables.

That giant command-line should probably be split out into a shell script anyway...

@lloeki lloeki changed the title Build issue Build issue on Windows Dec 31, 2015
@asadpiz
Copy link

asadpiz commented Feb 11, 2016

Ran into same issue, had to hardcode the $npm_package_electronVersion variable to "0.35.4" in package.json.

because of the value of variable: *"electronVersion": "0.35.4" * in the same file.

@markspolakovs
Copy link

FYI, a workaround is to edit the package.json file and under scripts -> build change $npm_package_productName and $npm_package_electronVersion to %npm_package_productName% and %npm_package_electronVersion%.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants