clang-format continues to recurse into directories listed in .clang-format-ignore

[synco]

Create a directory with a sub-directory. If we add the first directory into the ignore list, clang-format will still recurse into the sub-directory which is not expected.
Reasoning why it's not desirable, if you add a temporary build directory into the ignore list, clang-format will still format all files in sub-directories of the build directory.

Version: Ubuntu clang-format version 18.1.8 (++20240731024944+3b5b5c1ec4a3-1-exp1-20240731145000.144)

Recreate the directory structure, files, and execute clang-format:
mkdir -p level1/level2 && touch foo.c level1/bar.c level1/level2/bang.c && tree && echo 'level1/*' > .clang-format-ignore && shopt -s globstar && clang-format --verbose **/*
Result, it correctly ignores the file in level1 (bar.c), however continues to recurse into level2 (bang.c) which is not expected.

[owenca]

Create a directory with a sub-directory. If we add the first directory into the ignore list, clang-format will still recurse into the sub-directory which is not expected.

This is expected per the documentation.

Reasoning why it's not desirable, if you add a temporary build directory into the ignore list, clang-format will still format all files in sub-directories of the build directory.

We have DisableFormat for that.

[synco]

Where in the documentation? - as the behaviour I'm observing is not explicitly described. Using the DisableFormat option in a .clang-format file is less than ideal for the build directory example as the file needs to be generated in the build process.

…

On Wed, 6 Nov 2024 at 15:44, Owen Pan ***@***.***> wrote: Create a directory with a sub-directory. If we add the first directory into the ignore list, clang-format will still recurse into the sub-directory which is not expected. This is expected per the documentation <https://clang.llvm.org/docs/ClangFormat.html#clang-format-ignore>. Reasoning why it's not desirable, if you add a temporary build directory into the ignore list, clang-format will still format all files in sub-directories of the build directory. We have DisableFormat <https://clang.llvm.org/docs/ClangFormatStyleOptions.html#disableformat> for that. — Reply to this email directly, view it on GitHub <#114969 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAC6KME5RLMXK5YIP6DPTYDZ7F7AZAVCNFSM6AAAAABRGLTDRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJYGYYTQNRQGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[owenca]

Where in the documentation? - as the behaviour I'm observing is not explicitly described. Using the DisableFormat option in a .clang-format file is less than ideal for the build directory example as the file needs to be generated in the build process.

The linked documentation above specifically mentions and links to POSIX 2.13. It doesn't say that globstar is supported.

[synco]

It's not just globstar, as same unexpected behaviour with say find, eg:
find . -type f ( -name ".c" -o -name ".h" ) -exec clang-format -i --verbose {} +