Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Chat Model inputs not sanitized #1078

Open
2 tasks done
i13-ctflora opened this issue Jan 21, 2025 · 0 comments
Open
2 tasks done

Add Custom Chat Model inputs not sanitized #1078

i13-ctflora opened this issue Jan 21, 2025 · 0 comments
Labels
ux UX improvement

Comments

@i13-ctflora
Copy link

  • Disable all other plugins besides Copilot (required)
  • Screenshot of note + Copilot chat pane + dev console added (required)

Copilot version: v2.8.0

Describe how to reproduce
In the Settings -> Model -> Add Custom Model dialog, inputs are not trimmed. I was trying to add Perplexity as a custom model, and instead of typing the Model Name manually I was copy/pasting it from their site. Apparently, I was accidentally getting an extra space at the end of the model name. When I tried to verify the model, it failed with a 404 error. It took me almost 30 minutes and adding, testing, deleting, and repeating before I finally saw that tiny space.

Expected behavior
I'd like to see the inputs on this screen trimmed (left and right) of extra white space to avoid this issue in the future. I know it's entirely my fault, but my process is probably pretty common and this fix could potentially prevent future heartache, lol.

Screenshots
On the perplexity Supported Models page, if you double-click the model to select it, you can see that it includes an extra space at the end:

Image

And on pasting into the "Add Custom Chat Model" dialog, you can see the tiny space between the last letter and the cursor:

Image

Additional context
Again, I totally understand that this is my fault, but sanitizing the inputs on the dialog might make a smoother experience for other users because of the extra space in the selection on the perplexity website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux UX improvement
Projects
Status: Ready
Development

No branches or pull requests

2 participants