Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:date converter not working #47

Closed
colinsurprenant opened this issue May 11, 2017 · 2 comments · Fixed by #48
Closed

:date converter not working #47

colinsurprenant opened this issue May 11, 2017 · 2 comments · Fixed by #48

Comments

@colinsurprenant
Copy link
Contributor

The :date converter does not work. It produces a Ruby Date object which is not a class that the Event object supports.
OTOH the :date_time does work and could be use as a workaroud if the format is compatible.

In both cases, we should instead convert to a proper LogStash:Timestamp object and set it in the Event.

Also for both these cases we are missing specs.
@colinsurprenant colinsurprenant mentioned this issue May 23, 2017
Merged
@colinsurprenant
Copy link
Contributor Author

PR in #48

@colinsurprenant
Copy link
Contributor Author

followup issues #49 and #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@colinsurprenant