feature request: Set http client

[dennypenta]

What problem did you meet?

Injecting a http client as a dependency is necessary for observability and the others purposes.
For instance, in order to send a trace to OTLP trace provider we have to use our implementation of http.Client with custom http.Transport.

Describe what you'd like Logto to have

There are following options to achieve it:

• Add functional option pattern in order to keep the interface compatible, here is the good explanation: https://golang.cafe/blog/golang-functional-options-pattern.html, it can look the following:

func WithHttpClient(c *http.Client) func(*LogtoClient) {
  return func(logtoClient *LogtoClient) {
    logtoClient.httpClient = c
  }
}

• Add a setter for http.Client, In my opinion it shouldn't be thread safe, the client must be instantiate on the dependencies build step

func (logtoClient *LogtoClient) SetHttpClient(c *http.Client) {
  logtoClient.httpClient = c
}

[xiaoyijun]

Hi @dennypenta , thanks for your feedback, I will take a look.

[dennypenta]

hi @xiaoyijun
appreciate to hear any news.
it's quite minor change and it blocks to setup OTEL, the only option is to use my custom client or fork the sdk

[xiaoyijun]

Hi @dennypenta ,

Sorry for the delayed response! I said I would look into it but haven't had the chance to implement this yet.

Since you have a clear vision of how this feature should work and have already proposed some good solutions (like the functional options pattern), would you be interested in contributing this feature yourself? Your contribution would be greatly appreciated and would help other users who need OTEL integration!