Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible changes in v2.6.0: getColor() no longer supports URL input in Node environment #267

Open
ceynri opened this issue Oct 16, 2024 · 0 comments

Comments

@ceynri
Copy link

ceynri commented Oct 16, 2024

Problem

After updating to version 2.6.0, I encountered an issue when using the getColor method in a Node.js environment. When passing a web image url, the method throws an error: Input file is missing: https://xxxx.xxx/xxx.

Reason

Upon reviewing the source code, I noticed the issue stems from the fact that v2.6.0 now uses sharp for image processing, which does not support directly passing network image URLs. This functionality was available in previous versions, and it became unsupported without a major version update.

Suggestions

I think it would be good to handle network image input internally. This would help maintain backward compatibility. Alternatively, you could mention this change in the release notes. This way, users can understand the cause of the issue. They could then switch to passing a Buffer object or other methods to resolve it.

Anyway, thank you for still maintaining this repository!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant