Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log all actions (including movements, airlifts, disbands, buying) #2395

Open
hugomflavio opened this issue Sep 27, 2024 · 3 comments
Open

log all actions (including movements, airlifts, disbands, buying) #2395

hugomflavio opened this issue Sep 27, 2024 · 3 comments
Labels
enhancement New feature or request gui This issue requires changes to the user interface server This issue requires changes to the server

Comments

@hugomflavio
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Admins should be able to retrace every single action performed as the game goes on. That is currently not the case.

Describe the solution you'd like
Log every single action. Require e.g. a global observer with hack command level to see those detailed logs.

Describe alternatives you've considered
Dump every single action into a file/repository that only the game admin has access to.

Additional context
This will help the admin make informed decisions when e.g. a rule is reported to have been broken.

@hugomflavio hugomflavio added enhancement New feature or request Untriaged This issue or PR needs triaging labels Sep 27, 2024
@jwrober
Copy link
Collaborator

jwrober commented Oct 6, 2024

I see this as broken down into many steps:

  • Do the thing directly asked, plus...
  • New hack level - game admin
  • New "game admin" role that we can place in the players.serv file. Should probably support a 1 to many relationship so more than one person can be listed as a game admin
  • Change the server to accept the game admin role
  • Change the client to allow a game admin to connect as a global observer (all seeing) to the server with the role
  • Change the client to give a new interface that allows the game admin to see what happened
  • Then Ability to "undo" actions #2397

We also have the problem of #1762 that probably should be resolved if we do this. That's a lot of game data that is passed over the internet in plain text.

@jwrober jwrober added gui This issue requires changes to the user interface server This issue requires changes to the server and removed Untriaged This issue or PR needs triaging labels Oct 6, 2024
@lmoureaux
Copy link
Contributor

New hack level - game admin

I'd be more in favor of a "permissions" API for fcdb that queries whether a user can do some action (or, since we'll have to send this to the client, the list of actions a user can do).

Change the client to allow a game admin to connect as a global observer (all seeing) to the server with the role

It is already possible for game admins to /observe. This is handled through fcdb.

@hugomflavio
Copy link
Contributor Author

Very busy days for me nowadays with the new job, but once things calm down I'll happily help out where I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gui This issue requires changes to the user interface server This issue requires changes to the server
Projects
None yet
Development

No branches or pull requests

3 participants