Testing github

[Kevin551]

Hi I forked and downloaded the games in order to test the Ltex25 rulesets.
Am running the latest freeciv 2.5 beta2
The error on loading the ruleset is

Error loading the veteran system: "data/LTeX25/units.ruleset": Different lengths for the veteran settings in section 'unit_warriors'

I want to fix this and create a pull request in order to test the github system

[Kevin551]

Have looked up the latest change to noveteran code at freeciv dev and they offer a new way to provide the noveteran status

+; No veteran levels (level name is never displayed)
+veteran_names = _("green")
+veteran_raise_chance = 0
+veteran_work_raise_chance = 0
+veteran_power_fact = 100
+veteran_move_bonus = 0

see http://gna.org/bugs/?22203

[Kevin551]

I think a better solution is to allow the veteran warriors to be built but to demote them to green when the warrior is upgraded to a musketeer. Am looking up how to do this.

[Kevin551]

Sadly autoupgrade_veteran_loss is a game setting not an effect so it is not easy to force any one particular unit to lose levels while the others do not.

I just stated on the forum - I really dislike the noveteran change.

[Kevin551]

I think a better solution to the Leonardo wonder trick

; Number of veteran levels lost when auto-upgrading a unit
autoupgrade_veteran_loss = 1

it means all upgrades by the wonder will lose 1 veteran level. But this is a good thing because it creates a difference - pay for the upgrade in a city and keep the promotion or - get a free upgrade anywhere but lose the promotion.