Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement websockets #3

Open
lookfirst opened this issue Sep 10, 2017 · 4 comments
Open

Implement websockets #3

lookfirst opened this issue Sep 10, 2017 · 4 comments

Comments

@lookfirst
Copy link
Owner

This will probably help: n0mad01/node.bittrex.api#67

This code is a train wreck of complexity: https://github.com/codemanki/cloudscraper/
@harry-sm
Copy link
Contributor

@lookfirst
I could help with this I did add it to my own lib.
I recently resorted to cloudscraper to address the 503 error.

@lookfirst
Copy link
Owner Author

@harry-sm Happy to get the PR's... to be honest, I've moved off bittrex and I'm using another exchange now. The feeling they gave me based on the quality of their API and attitude in their chat room made me not trust them as an exchange at all. It feels like they are one hack away from their wallet being emptied...

@lookfirst
Copy link
Owner Author

@harry-sm Your code looks pretty decent. A few style issues, but overall not bad. If you'd like to merge our two projects, I'm totally fine with that.

@harry-sm
Copy link
Contributor

@lookfirst
Thanks. Merging is not a bad idea but not everyone want to use rxjs it's kinda a niche, but lets chat about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lookfirst @harry-sm