Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make String methods for logged dPoS types #244

Open
aupiff opened this issue Jan 15, 2019 · 2 comments
Open

make String methods for logged dPoS types #244

aupiff opened this issue Jan 15, 2019 · 2 comments

Comments

@aupiff
Copy link
Contributor

aupiff commented Jan 15, 2019

All logged dPoS types should have pretty printing String() methods to make the logs readable.

@aupiff aupiff changed the title make String methods for logged types make String methods for logged dPoS types Jan 15, 2019
@gakonst
Copy link
Contributor

gakonst commented Jan 15, 2019

All methods generated by protoc have this https://github.com/loomnetwork/go-loom/blob/master/builtin/types/dposv2/dposv2.pb.go#L260

We need to override them so that they print everything in human readable form for more awkard types such as []byte

@aupiff
Copy link
Contributor Author

aupiff commented Jan 15, 2019

The issues seem to be with pubkey readability. Perhaps the easiest solution if just to make the pubkeys have a type alias over []byte & for that type alias to have a nice String() function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants