Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash during marshaling #260

Open
coinsandsteeldev opened this issue Jan 30, 2019 · 0 comments
Open

Crash during marshaling #260

coinsandsteeldev opened this issue Jan 30, 2019 · 0 comments

Comments

@coinsandsteeldev
Copy link

coinsandsteeldev commented Jan 30, 2019

One of my methods returned nil pointer with type pb.Message. As it turned out reflection magic makes it "legit" interface pointer with 0 value. Nil check here happens to be valid.

There are 2 ways:

  1. Make sure that nobody returns nil messages.
  2. Make it actually work

I prefer 2nd solution and here is the fix,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant