Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a meaningful message after withdraw #20

Open
andreipope opened this issue Nov 19, 2018 · 1 comment
Open

Add a meaningful message after withdraw #20

andreipope opened this issue Nov 19, 2018 · 1 comment

Comments

@andreipope
Copy link

Below message is displayed after withdraw command is executed:

Withdrawing db0d1408e211fc91
Withdrew [object Object]

There is no easy way to find out is the operation was successful or not. Can we have a meaningful message instead?
@gakonst
Copy link
Contributor

gakonst commented Nov 19, 2018

Should make https://github.com/loomnetwork/loom-js/blob/master/src/plasma-cash/entity.ts#L491 to also setup a Withdrew event listener so that it logs success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gakonst @andreipope