Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: dynamically updated LB3 API (routes + spec) #2394

Closed
bajtos opened this issue Feb 14, 2019 · 3 comments
Closed

Spike: dynamically updated LB3 API (routes + spec) #2394

bajtos opened this issue Feb 14, 2019 · 3 comments

Comments

@bajtos
Copy link
Member

bajtos commented Feb 14, 2019

This is a follow-up for the spike #2318, see the discussion and PoC code for more context.

In LB3, it's possible to change the shape of REST API at runtime by adding or removing shared methods or even entire models.

The PoC version of LB3+LB4 does not support spec updates, we need to do a spike to find the best solution. (For example, mountExpressRouter can accept a spec getter instead of the spec object.)

As for the actual request handling, the PoC version reloads route handlers in "full" mode but does not reload in "router" mode. As part of the stories created from the spike, we should fix "router" mode to reload the LB3 handler when needed.

Related issues: #1849 #2389 #2391

@jannyHou
Copy link
Contributor

time box the spike to one week.

@dhmlau dhmlau added 2019Q3 and removed 2019Q2 labels Apr 16, 2019
@dhmlau dhmlau added the p2 label Jun 25, 2019
@dhmlau dhmlau added 2019Q4 and removed 2019Q3 labels Aug 15, 2019
@dhmlau dhmlau added the p3 label Sep 25, 2019
@dhmlau dhmlau removed 2019Q4 labels Oct 3, 2019
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Oct 4, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants