Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] run integration tests on a real HSM and SoftHSM2 in presubmit #17

Open
1 of 2 tasks
timothytrippel opened this issue Sep 11, 2024 · 0 comments
Open
1 of 2 tasks

[ci] run integration tests on a real HSM and SoftHSM2 in presubmit #17

timothytrippel opened this issue Sep 11, 2024 · 0 comments
Assignees
@moidx
Labels
enhancement New feature or request

Comments

@timothytrippel
Copy link
Collaborator

timothytrippel commented Sep 11, 2024 •
edited
Loading

We only currently run the following tests in presubmit:

  • lint checks
  • build and unit tests
  • airgapped build tests

We should also run E2E integration tests, using run_integration_tests.sh script, using both:

  • a real Thales Luna HSM, and
  • SoftHSM2,
    in presubmit. This will require setting up dedicated CI resources for these tests.
@timothytrippel timothytrippel added the enhancement New feature or request label Sep 11, 2024
@timothytrippel timothytrippel changed the title [ci] run integration tests on real HSMs in presubmit [ci] run integration tests on a real HSM and SoftHSM2 in presubmit Sep 29, 2024
@timothytrippel timothytrippel self-assigned this Sep 29, 2024
@timothytrippel timothytrippel mentioned this issue Oct 1, 2024
Merged
@timothytrippel timothytrippel removed their assignment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moidx moidx

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moidx @timothytrippel