Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prim_reg_cdc, CDC boundary] RTL simplification to avoid CCOV unreachable gap #26164

Open
antmarzam opened this issue Feb 7, 2025 · 0 comments
Open

[prim_reg_cdc, CDC boundary] RTL simplification to avoid CCOV unreachable gap #26164

antmarzam opened this issue Feb 7, 2025 · 0 comments
Assignees
@antmarzam
Labels
Component:CDC Related to CDC flow Component:RTL IP:prim Type:FutureRelease Not relevant to currently planned releases/milestones

Comments

@antmarzam
Copy link
Contributor

Description

Prim_reg_cdc has some conditional coverage which looks unhittable and it would be helpful to have a simpler condition to close coverage rather than having an waiver exclusion for each instance.

The reasoning of why this is not reachable can be found here

There's an outstanding PR aiming to simplify the condition. As of now the PR won't be merged until we do the next CDC sign-off.

Action: revisit this issue once we tackle CDC sign-off again.
@antmarzam antmarzam added Component:CDC Related to CDC flow Type:FutureRelease Not relevant to currently planned releases/milestones labels Feb 7, 2025
@antmarzam antmarzam self-assigned this Feb 7, 2025
@antmarzam antmarzam mentioned this issue Feb 7, 2025
Closed
antmarzam added a commit to antmarzam/opentitan that referenced this issue Feb 7, 2025
@antmarzam
[dv, aon_timer] Waiving RTL unreachable statements pending rtl change
7cf94f9 
These exclusions cover the missing branch/line coverage for aon_timer.
Once are PRs  lowRISC#25812/lowRISC#26072 make it to maste these exclusions can be
ammendeed/removed.

There's also a github issue lowRISC#26164 to re-evaluate the RTL changes which may
affect CDC sign-off.

Signed-off-by: Antonio Martinez Zambrana <[email protected]>
@antmarzam antmarzam mentioned this issue Feb 7, 2025
Open
antmarzam added a commit to antmarzam/opentitan that referenced this issue Feb 7, 2025
@antmarzam
[dv, aon_timer] Waiving RTL unreachable statements pending rtl change
efeaf2e 
These exclusions cover the missing branch/line coverage for aon_timer.
Once are PRs  lowRISC#25812/lowRISC#26072 make it to maste these exclusions can be
ammendeed/removed.

There's also a github issue lowRISC#26164 to re-evaluate the RTL changes which may
affect CDC sign-off.

Signed-off-by: Antonio Martinez Zambrana <[email protected]>
antmarzam added a commit to antmarzam/opentitan that referenced this issue Feb 7, 2025
@antmarzam
[dv, aon_timer] Waiving RTL unreachable statements pending rtl change
857de0c 
These exclusions cover the missing branch/line coverage for aon_timer.
Once are PRs  lowRISC#25812/lowRISC#26072 make it to maste these exclusions can be
ammendeed/removed.

There's also a github issue lowRISC#26164 to re-evaluate the RTL changes which may
affect CDC sign-off.

Signed-off-by: Antonio Martinez Zambrana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antmarzam antmarzam

Labels
Component:CDC Related to CDC flow Component:RTL IP:prim Type:FutureRelease Not relevant to currently planned releases/milestones
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antmarzam