Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametric EQ redesign #3

Open
16 of 26 tasks
PROPHESSOR opened this issue Dec 17, 2023 · 6 comments
Open
16 of 26 tasks

Parametric EQ redesign #3

PROPHESSOR opened this issue Dec 17, 2023 · 6 comments
Assignees

Comments

@PROPHESSOR
Copy link

PROPHESSOR commented Dec 17, 2023

  • Enable FFT by default
    image

  • Pre + Post FFT option
    image

  • Reasonable gain range by default (not 36 db 🤯) (make a dropdown list like in FabFilte Pro Q3 with 6db, 12db, 24db, 36db options and select 12db by default)
    image

  • Highlight the filter when user clicks on the corresponding point
    image

  • Make points bigger
    image
    image

  • Don't hide points of muted filters

  • Show the gain near the point
    image

  • Don't show unused filters at the bottom
    image

  • Mute/unmute dot on double click on it

  • Move filters selection buttons
    image

  • Move presets from Menu to a panel
    image

  • Move filter params to a floating window and expand the working space by removing unnecessary bottom panel
    image
    image
    image
    image

  • Added after 18.12.2023

  • Interpolate FFT output
    image

  • Do you really need this Balance knob? Or shouldn't it be changed to "Pan"?
    image

  • Add FFT tilt combo box
    image

  • Added after 20.12.2023

  • Hide this knob when AUTO button isn't active
    image

  • Add tooltip hints on button hover (needed for INSPECT, AUTO, Mode, Pitch, Reactivity, Mode, etc)

  • Change Zoom slider appearance
    image

  • Verify SAVE/LOAD, Import/Export and Presets options... Move Presets to the top banel (see proporsal above), Import/Export stay in the menu and SAVE/LOAD/RESET move to the Presets window
    image

  • Add automatic gain compensation button

  • Add more options to dot context menu:

    • Invert gain
    • Delete
  • Add invert phase button?

  • Change Q range for more convenient usage

  • Add channel option for a filter:

    • Stereo
    • Left
    • Right
    • Mid
    • Side
      image
  • Ctrl+Click to delete a dot

  • Add optional phase curve (like in ReaEQ)

Image

  • Add "History" or "Freeze" or "Accumulated" spectre view
    Image
  • Add frequency peaks highlight (like in FLStudio's EQ 2)
@sadko4u
Copy link
Collaborator

sadko4u commented Dec 17, 2023

Hello!

Enable FFT by default
Pre + Post FFT option

These features already will be available in the upcoming release.

Reasonable gain range by default (not 36 db 🤯) (make a dropdown list like in FabFilte Pro Q3 with 6db, 12db, 24db, 36db options and select 12db by default)

This is not too hard to implement The idea with combo is bad, slider is much more flexible.

Make points bigger

This can be done as an configurable option. All who want points bigger will be able to change it.

Don't hide points of muted filters

This only conforms with the case when there is no panel with all filters listed. Need to explore.

Show the gain near the point

Good proposal, easy to implement.

All other things are related to serious UI changes and there are still things to discuss. Not in the upcoming release.

@PROPHESSOR
Copy link
Author

PROPHESSOR commented Dec 17, 2023

This is not too hard to implement The idea with combo is bad, slider is much more flexible.

Maybe, but it's not so convenient that the slider also changes FFT zoom...
And it took me a while to realize that blue thing was a slider
Why don't you like the idea with combo? Do you really need smooth max-gain change?..

This can be done as an configurable option. All who want points bigger will be able to change it.

But why aren't they by default? It's about usability on small screens/touchpads/touchscreens
If you check other EQs, you will find that these points are much bigger for that reason
image
image
image
image

This only conforms with the case when there is no panel with all filters listed. Need to explore.

Yeah and it will be more convenient if you can toggle filters on/off using the points. Because for now you need to find the needed filter on the panel...

All other things are related to serious UI changes and there are still things to discuss. Not in the upcoming release.

In general, I wanted to switch from the FabFilter plugins pack to something open source and with native Linux support.
Among the plugins that I found, your project has is the most powerful tools, I was just shocked by their capabilities

But they have a serious problem: when I first opened them, my eyes just ran wild... A bunch of sections with a bunch of knobs each that have the same size... Because of this, it’s difficult to learn how to work with such tools, because sometimes it’s difficult to just find the right knob

For example, the main parameters of a compressor are threshold and level, but in LSP these knobs are no different from all the others, although, in theory, they should be the largest and take user's attention first

In terms of functionality, LSP is superior to many expensive plugin packages, but it is difficult for beginners to use due to the excessively complex UI

If you are interested, I can make a list of what can be improved in terms of the interface to make it more understandable for an untrained user, so that it can be worked with quickly

The same 20% that gives you 80% of the results

@sadko4u
Copy link
Collaborator

sadko4u commented Dec 18, 2023

Maybe, but it's not so convenient that the slider also changes FFT zoom...

In the upcoming release it is also configurable as proposed @bor-T .

But why aren't they by default? It's about usability on small screens/touchpads/touchscreens
If you check other EQs, you will find that these points are much bigger for that reason

Because wide dots take too much space on the graph, so I found the best size to work with plugin on PC. Your argument about touchscreens is understandable. And that's why I think it is a customizable option.

If you are interested, I can make a list of what can be improved in terms of the interface to make it more understandable for an untrained user, so that it can be worked with quickly

We can collaborate with @bor-T who is also responsible for the plugin design to find the best UI solutions.
So here we're open but not all things can be done immediately.

We have private development chat in Telegram and can invite you if you're interested.

@sadko4u
Copy link
Collaborator

sadko4u commented Dec 18, 2023

Yet more info. Yesterday I verified and implemented almost all mentioned in this post:
#3 (comment)

I think more complicated UI solutions should be discussed and decomposed into separate tasks.

Also please open further discussions here:
https://github.com/sadko4u/lsp-plugins/issues

It is common issue tracker for all plugins in the package.

@sadko4u
Copy link
Collaborator

sadko4u commented Dec 18, 2023

Is it a slope parameter? If yes, does it work? I can't see any changes... Also, it's more convenient to use dropdown list for it with short comments for beginners (like white noise/pink noise/etc)

Just press the 'AUTO' button and drag some bell filter.

Do you really need this Balance knob? Or shouldn't it be changed to "Pan"?

No, Balance controls relative level between left and right channel. Pan controls the amount of left channel mixed to right channel and vice verse. This button is useful when you get some loudness differences between left and right channels.

Interpolate FFT output

Yes, it can be done but has some drawbacks:

  • Interpolation requires additional CPU computations. Not too many but still they'll be.
  • It hides understanding of FFT. I met people who did not understand that FFT has lower resolution in low-end rather than on high frequencies thanks to the interpolated frequency graphs.

Why don't you like the idea with combo? Do you really need smooth max-gain change?..

At least it is more flexible. You can just set the desired scale and work with it instead of some restricted and predefined one.

@PROPHESSOR
Copy link
Author

PROPHESSOR commented Dec 18, 2023

Because wide dots take too much space on the graph, so I found the best size to work with plugin on PC. Your argument about touchscreens is understandable. And that's why I think it is a customizable option.

As an option, you can make them stroke (I mean border-only, without the filling)

We have private development chat in Telegram and can invite you if you're interested.

Yeah, I'm interested in the growth of this project and would like to help) I speak English/Russian/Ukrainian

Also please open further discussions here:
https://github.com/sadko4u/lsp-plugins/issues
It is common issue tracker for all plugins in the package.

Okay

Just press the 'AUTO' button and drag some bell filter.

Oh... I misunderstood it. I thought it's a tilt factor of the EQ
Is it implemented?

Yes, it can be done but has some drawbacks:

It can be made configurable

This button is useful when you get some loudness differences between left and right channels.

Is it a common case in EQ? I think it should be done before the EQ, because it's not its responsibility...

Also there's a "Pitch" knob that does something strange... It just moves all filters frequencies... This can be useful for sound synthesis from noises or similar techniques and often exists in some filter plugins but not a common use of an equalizer...
Also I think it should be renamed to "Shift" of something like that because "Pitch" is more about transposing the signal and it will likely misunderstood

Or these knobs can be hidden to some optional "Advanced" panel to reduce knobs amount for non-pro users

@PROPHESSOR PROPHESSOR self-assigned this Dec 22, 2023
@PROPHESSOR PROPHESSOR changed the title Some feature requests and ideas Parametric EQ redesign Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants