Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need new version for Nx@18 #191

Closed
kylebjordahl opened this issue Mar 3, 2024 · 0 comments · Fixed by #192
Closed

Need new version for Nx@18 #191

kylebjordahl opened this issue Mar 3, 2024 · 0 comments · Fixed by #192
Assignees
Labels
enhancement New feature or request

Comments

@kylebjordahl
Copy link
Contributor

kylebjordahl commented Mar 3, 2024

Current Behavior

Cannot add @nxlv/python plugin to workspace with Nx 18

Expected Behavior

Plugin installs

Steps to Reproduce

  1. npm install @nxlv/[email protected]

Nx Report

NX   Report complete - copy this into the issue template

Node   : 20.11.1
OS     : darwin-arm64
npm    : 10.2.4

nx                 : 18.0.6
@nx/js             : 18.0.6
@nx/linter         : 18.0.6
@nx/eslint         : 18.0.6
@nx/workspace      : 18.0.6
@nx/cypress        : 18.0.6
@nx/devkit         : 18.0.6
@nx/eslint-plugin  : 18.0.6
@nx/react          : 18.0.6
@nx/remix          : 18.0.6
@nrwl/tao          : 18.0.6
@nx/vite           : 18.0.6
@nx/web            : 18.0.6
typescript         : 5.3.3

Failure Logs

Executing task: npm install  @nxlv/[email protected] 

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @kb_nx_architect/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/nx
npm ERR!   dev nx@"18.0.6" from the root project
npm ERR!   peer nx@">= 16 <= 18" from @nx/[email protected]
npm ERR!   node_modules/@nx/devkit
npm ERR!     peer @nx/devkit@"^17.0.0" from @nxlv/[email protected]
npm ERR!     node_modules/@nxlv/python
npm ERR!       @nxlv/python@"17.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer nx@"^17.0.0" from @nxlv/[email protected]
npm ERR! node_modules/@nxlv/python
npm ERR!   @nxlv/python@"17.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/kyle/.npm/_logs/2024-03-03T00_35_14_316Z-eresolve-report.txt

Additional Information

Per release notes, v18 was a major release due to Project Crystal, but contains no breaking changes. Support for v18 in this plugin should be a simple as fixing the peer dependency.

While this can be circumvented with --force that leads to errors/warnings on subsequent NPM installs.

@kylebjordahl kylebjordahl added bug Something isn't working needs-triage This issue needs triage labels Mar 3, 2024
@lucasvieirasilva lucasvieirasilva added enhancement New feature or request and removed bug Something isn't working needs-triage This issue needs triage labels Mar 5, 2024
@lucasvieirasilva lucasvieirasilva self-assigned this Mar 5, 2024
lucasvieirasilva added a commit that referenced this issue Mar 6, 2024
also migrate from jest to vitest

BREAKING CHANGE: To use this version the nx workspace needs to be migrated to version 18.x

re #191
@lucasvieirasilva lucasvieirasilva linked a pull request Mar 6, 2024 that will close this issue
lucasvieirasilva added a commit that referenced this issue Mar 6, 2024
also, migrate from jest to vitest

BREAKING CHANGE: To use this version the nx workspace needs to be migrated to version 18.x

re #191
github-actions bot pushed a commit that referenced this issue Mar 6, 2024
# [4.0.0](util-v3.0.0...util-v4.0.0) (2024-03-06)

### Features

* add support for nx 18.x ([#192](#192)) ([03b9aa0](03b9aa0)), closes [#191](#191)

### BREAKING CHANGES

* To use this version the nx workspace needs to be migrated to version 18.x
github-actions bot pushed a commit that referenced this issue Mar 6, 2024
# [4.0.0](data-migration-v3.0.0...data-migration-v4.0.0) (2024-03-06)

### Features

* add support for nx 18.x ([#192](#192)) ([03b9aa0](03b9aa0)), closes [#191](#191)

### BREAKING CHANGES

* To use this version the nx workspace needs to be migrated to version 18.x
github-actions bot pushed a commit that referenced this issue Mar 6, 2024
# [18.0.0](nx-python-v17.0.0...nx-python-v18.0.0) (2024-03-06)

### Features

* add support for nx 18.x ([#192](#192)) ([03b9aa0](03b9aa0)), closes [#191](#191)

### BREAKING CHANGES

* To use this version the nx workspace needs to be migrated to version 18.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants