Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expansion_factor on tokens should applied to hidden dim not to num_patches #16

Open
ease-zh opened this issue Dec 6, 2024 · 0 comments

Comments

@ease-zh
Copy link

ease-zh commented Dec 6, 2024

#11 has notice the problem about the expansion_factor on tokens.
But, in the official implemtention, and also in the papers, the dimension for tokens mlp is actually half of the hidden dim, and is not relevant to the num of patches.

The most intuitive evidence is that, for the same image resolution, i.e. the same num of patches, the S/M/L/B models has different MLP dimension Ds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant