-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LUG location map doesn't always seem to be centring on/showing the correct location #159
Comments
This was because this information was provided by someone generously adding a "best guess" given the details provided. It probably should be reviewed on the next pass! |
It's more than that, as per #143, Shropshire is showing a map that doesn't even include the part of the country where Telford is (and I had updated the co-ordinates to be the mentioned pub, but they weren't that far out): |
+1 (peterboro LUG). Every page I checked showed the same map centred on North Pennines AONB - not a bad place to be centred but not much use from a LUG map POV. |
Ahhhhh... actually, I did get billed (admittedly, £0.01) by Google for the use of their Maps API. I wonder if my card was rejected and they've turned off rendering? :) Perhaps we should revisit using another mapping provider? |
I'd certainly be happy to look at other providers. Maybe OpenStreetMap? I've not looked at what their API is like though to know how easy it would be to use. |
OpenStreetMap wiki gives a straightforward way to generate an iFrame containing a map, from there "all" you need is a set of coordinates per LUG, although you need that whatever mapping you use. |
@hollymcr Thanks. Looking at their website, they recommend the use of https://leafletjs.com. Their API is at https://leafletjs.com/reference.html. I might have a play with it at the weekend to see how we could implement it for the LUG mapping. |
That seems unnecessarily complex (albeit that having played a bit with leaflet in the past it's fun to play with). According to the OSM wiki it says to just embed the HTML generated by the share option on the OSM website. So the code for the Peterborough LUG would be something like: I'm sure it could be tweaked with markers etc if needed. But the end result ought to be a template to which some map coords are applied per LUG. |
There seems to be an issue with the maps to show the LUG location. Several reports of it showing or centring on completely different parts of the country
The text was updated successfully, but these errors were encountered: