Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@tsoa/runtime v6.6.0 introduces a breaking change in IocContainer #1729

Closed
nuKs opened this issue Dec 10, 2024 · 4 comments
Closed

@tsoa/runtime v6.6.0 introduces a breaking change in IocContainer #1729

nuKs opened this issue Dec 10, 2024 · 4 comments

Comments

@nuKs
Copy link

nuKs commented Dec 10, 2024

@tsoa/runtime v6.6.0 introduces a breaking change in IocContainer.

It no longer support the { prototype: T } interface.

See ecfc00c#diff-7a6af74976de11e4ba5076299260544f42d3343f9630043618dd2d273dcc7decR14

@nuKs nuKs changed the title Version 6.6 induce breaking change in iocContainer @tsoa/runtime v6.6.0 introduces a breaking change in IocContainer Dec 10, 2024
Copy link

Hello there nuKs 👋

Thank you for opening your very first issue in this project.

We will try to get back to you as soon as we can.👀

@helios-ag
Copy link
Contributor

You can read related discussion here
inversify/InversifyJS#1629

@nuKs
Copy link
Author

nuKs commented Dec 11, 2024

@helios-ag thanks for the care taken considering the issue and documenting in inversify

cause: non-semvers breaking change in a sub-dependencies

only fix for user is:

  • to stay on 6.5.x
  • adapt the implementation

@WoH
Copy link
Collaborator

WoH commented Jan 7, 2025

I mean, is it great? No.
But tbh, I am not sure why this is a tsoa issue, not a inversify issue.
If you think types should not break between minors, and that may be your opinion (it's hard, see TS itself), then we are just passing thought the dep incompat.

@WoH WoH closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants