Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks deprecation #1

Open
dijonkitchen opened this issue Mar 4, 2019 · 3 comments
Open

Hooks deprecation #1

dijonkitchen opened this issue Mar 4, 2019 · 3 comments

Comments

@dijonkitchen
Copy link

dijonkitchen commented Mar 4, 2019

Warning: implicit hook found: lein-cprop.plugin/hooks 
Hooks are deprecated and will be removed in a future version.

https://github.com/technomancy/leiningen/blob/master/doc/PLUGINS.md#hooks

Other relevant information:
technomancy/leiningen#2387

@yogthos
Copy link
Member

yogthos commented Mar 5, 2019

Any chance you would be up for doing a pr to remove the hook?

@dijonkitchen
Copy link
Author

Sorry, I don't know how to do this right now, but wanted to note it for anyone else trying to figure it out.

@yogthos
Copy link
Member

yogthos commented Mar 26, 2019

As a note, the plugin is no longer used in Luminus because config is read from an external file such as dev-config.edn. So, while it would be good to fix it, the usage pattern is deprecated.

aatkin added a commit to CSCfi/rems that referenced this issue Mar 1, 2024
aatkin added a commit to CSCfi/rems that referenced this issue Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants