Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ring websocket API support #29

Open
weavejester opened this issue Oct 17, 2023 · 1 comment · May be fixed by #30
Open

Ring websocket API support #29

weavejester opened this issue Oct 17, 2023 · 1 comment · May be fixed by #30

Comments

@weavejester
Copy link

weavejester commented Oct 17, 2023 •
edited
Loading

I've been working on a Ring websocket API that's currently in experimental alpha. Would you be interested in a PR to support this in Luminus to be merged when the Ring websocket API is stable?

The reason I'm asking this while the Ring API is still experimental is that I'd like to try implementing the API for different third-party adapters, so I can get feedback and forewarning of any design issues. I've submitted a similar issue to the ring-jetty9-adapter project, and another one to http-kit.
@yogthos
Copy link
Member

yogthos commented Oct 17, 2023

Oh yeah, a PR would be very welcome, I think experimental status is fine. We can add a note regarding that in the readme.

@weavejester weavejester linked a pull request Nov 5, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Ring websocket API (WIP) weavejester/ring-undertow-adapter
2 participants
@weavejester @yogthos