PT012 possible false positive: context manager that catches exceptions

[SwampFalc]

@contextmanager
def cli():
    interface = CLI()
    try:
        yield interface
    except subprocess.CalledProcessError as cpe:
        traceback.print_exc()
        interface.warning(f"stdout: {cpe.stdout}")
        interface.error(f"stderr: {cpe.stderr}")
        sys.exit(1)

This context manager was built to provide a commandline interface. Since during the execution of the rest of the code, a number of subprocess calls happen and, well, there's always a chance of unexpected errors there, I placed this try/except in there. This ensures that in case of unexpected error, as much info as possible is printed.

However, I have found that I cannot test this with just a "simple statement". The most basic test I can run is this:

def test_cli(capsys):
    with pytest.raises(SystemExit):
        with library.cli():
            raise CalledProcessError(1, "cmd", output="findme", stderr="findmetoo")

    stdout, stderr = capsys.readouterr()
    assert stdout.splitlines() == ["stdout: findme", "stderr: findmetoo"]

Now, I did read #93 so I am aware of the possible work arounds.

But I thought I might file this bug report in case you do see a simpler way of testing it, or if maybe you saw a way to add it as an exception.

[webknjaz]

@SwampFalc one way is to go low-level:

- def test_cli(capsys):
+ def test_cli(capsys: pytest.CaptureFixture[str]) -> None:
+     cli_ctx_mgr = library.cli()
+     cli_ctx_mgr.__enter__()
-     with pytest.raises(SystemExit):
+     with pytest.raises(SystemExit, match=r'^$'):
-         with library.cli():
-             raise CalledProcessError(1, "cmd", output="findme", stderr="findmetoo")
+         cli_ctx_mgr.gen.throw(CalledProcessError(1, "cmd", output="findme", stderr="findmetoo"))

      stdout, stderr = capsys.readouterr()
      assert stdout.splitlines() == ["stdout: findme", "stderr: findmetoo"]