New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up from GoToMyPC use case with ndt7-client-go #66

Open

4 of 5 tasks

stephen-soltesz opened this issue Apr 13, 2022 · 1 comment

Open

4 of 5 tasks

Follow up from GoToMyPC use case with ndt7-client-go #66

stephen-soltesz opened this issue Apr 13, 2022 · 1 comment

Assignees

Contributor

stephen-soltesz commented Apr 13, 2022 •

edited by robertodauria

Loading

Remove notice from README.md #65
Make ClientName and ClientVersion overridable at build time #71
Provide example command to set main.go ClientName at build time. See for example: https://github.com/m-lab/ndt-server/blob/master/build.sh#L11-L18
Try next available server on doConnection failure #58
What are the set of errors returned by ndt7-client go?

autolabel bot added the review/triage label

stephen-soltesz assigned robertodauria

stephen-soltesz removed the review/triage label

Contributor

robertodauria commented Apr 27, 2022

After #71 is merged, building the client with these flags allows to set a custom ClientName:

CLIENTNAME=my-client-name

go build -ldflags "-X main.ClientName=$CLIENTNAME" ./cmd/ndt7-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment