Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input field for port is too small #797

Open
nugel opened this issue Dec 7, 2021 · 7 comments · May be fixed by #943
Open

Input field for port is too small #797

nugel opened this issue Dec 7, 2021 · 7 comments · May be fixed by #943

Comments

@nugel
Copy link

nugel commented Dec 7, 2021

Given that Monero is using ports 18080 and 18081 for the mainnet (testnet has ports "visually" even longer"), the field for port input is just too short. It would be suitable if the port field was at least one character wider and perhaps the default mainnet port for RPC prefilled.

Steps to simulate:

  1. open the app
  2. click the node
  3. click the plus button
  4. in the port field, enter 18080

photo_2021-12-07_23-56-01
I'm incredibly sorry for the "screenshot" but there is no other way to capture screen as Monerujo doesn't allow changing the settings to allow it.

Monerujo version 2.1.2 11020
Android 12, Pixel 6 Pro

@m2049r
Copy link
Owner

m2049r commented Dec 29, 2021

yeah, it's horrible. This whole popup should be it's own screen. With space for stuff :)

@shortwavesurfer2009
Copy link

I have placed a bounty for this

@shortwavesurfer2009
Copy link

A PR for this is very close. If you look at the bounty comments it is close to being ready

@anhdres
Copy link
Contributor

anhdres commented Apr 29, 2024

Sorry I missed this thread, we already had two designs for it, one as a pop up and one for a full screen. This issue just got forgotten in the deep pit of to-do UX tweaks:

image

I think we all pretty much agree it should be a full screen at this point.

@shortwavesurfer2009
Copy link

Well, the dev has already almost completed the work so it will still be submitted anyway. Nothing was mentioned about this until right now. I think the dev should have a chance to submit their work for consideration and be paid for it, though that is more up to plowsof

@Justxd22 Justxd22 linked a pull request Apr 29, 2024 that will close this issue
@anhdres
Copy link
Contributor

anhdres commented Apr 29, 2024

I have nothing against he getting paid his bounty! Ultimately, when it comes to code, it's always @m2049r who can judge if it works or not. If we're purely talking UI design, I don't want to discourage any contribution, the more we get the better.

@anhdres
Copy link
Contributor

anhdres commented Apr 30, 2024

There are a lot of UI/UX pending tweaks that we don't publish or publicly disclose until they're live. But again, that's not to discourage people helping us with the workload, that's really welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants