Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Unlabeled and unusable elements with talkback (0.5XMR) #933

Open
5 tasks
shortwavesurfer2009 opened this issue Mar 21, 2024 · 4 comments · May be fixed by #945
Open
5 tasks

Accessibility: Unlabeled and unusable elements with talkback (0.5XMR) #933

shortwavesurfer2009 opened this issue Mar 21, 2024 · 4 comments · May be fixed by #945

Comments

@shortwavesurfer2009
Copy link

shortwavesurfer2009 commented Mar 21, 2024 •
edited
Loading

On the wallet select screen

  • the "+" icon is labeled as "create new wallet" instead of something like "create or restore wallet" which would be more accurate

  • When the "+" is pressed the menu options for "create new wallet", "restore view-only wallet", "restore wallet from private keys", "restore wallet 25 word seed", and "import wallet", cannot be focused by talkback at all and cannot be used.

  • When the "+" button is pressed the "x" it becomes still reads as "create new wallet" instead of "close"

On the nodes screen

  • the heart icon for saving or unsaving nodes reads as "unlabeled". I suggest "remove saved node" when the heart is fully red and "save node" when it is only the outline

When a wallet is open

  • the three line hamburger menu at the top left reads as "unlabeled"

Edit: A bounty to fix this
@anhdres
Copy link
Contributor

anhdres commented Mar 21, 2024

Thank you for taking the effort to help us make the wallet more accesible.

@shortwavesurfer2009
Copy link
Author

@anhdres its selfish since I rely on accessibility myself. It just happens to be good for more than just me.

@anhdres
Copy link
Contributor

anhdres commented Mar 21, 2024

I don't think it's selfish. It's like me wanting to have real ARS/XMR prices in the app, it's useful for me, but also to a lot of people that doesn't know how to ask for it.

If it wasn't for you, we'd simply not notice. Keep us pinged and we'll do our best.

@shortwavesurfer2009 shortwavesurfer2009 changed the title Accessibility: Unlabeled and unusable elements with talkback Accessibility: Unlabeled and unusable elements with talkback (0.1XMR) Apr 25, 2024
@shortwavesurfer2009 shortwavesurfer2009 changed the title Accessibility: Unlabeled and unusable elements with talkback (0.1XMR) Accessibility: Unlabeled and unusable elements with talkback (0.2XMR) Apr 25, 2024
@shortwavesurfer2009 shortwavesurfer2009 changed the title Accessibility: Unlabeled and unusable elements with talkback (0.2XMR) Accessibility: Unlabeled and unusable elements with talkback (0.5XMR) Apr 26, 2024
@detherminal detherminal linked a pull request May 4, 2024 that will close this issue
Open
@plowsof
Copy link

plowsof commented Oct 3, 2024

i have confirmed that all issues have been addressed in detherminals branch / workflow run @ https://github.com/detherminal/xmrwallet/actions/runs/11159241005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: accesibility labels for buttons detherminal/xmrwallet
3 participants
@anhdres @plowsof @shortwavesurfer2009