Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend SLH class to allow for description of port names and optionally keep track of eliminated internal modes #9

Open
ntezak opened this issue Nov 5, 2015 · 0 comments
Open

Extend SLH class to allow for description of port names and optionally keep track of eliminated internal modes #9

ntezak opened this issue Nov 5, 2015 · 0 comments
Assignees
@ntezak
Labels
QHDL issue should be moved to QHDL package

Comments

@ntezak
Copy link
Contributor

ntezak commented Nov 5, 2015

It would be quite useful to store more metadata with an SLH object, such as the labels of inputs and outputs as well as any internal signals that were eliminated through feedforward/feedback. Ideally we would also store scattering matrices and L operators for the internal modes, which can then be used to compute transfer functions from external input to some internal mode, and to give the expected mode amplitudes for internal modes. The QHDLJ package I wrote supports this through the ABCD formalism as well. We still need to figure out if this can be generalized from this almost linear case.
@ntezak ntezak self-assigned this Nov 5, 2015
@ntezak ntezak added the enhancement new or improved features label Nov 5, 2015
@ntezak ntezak mentioned this issue Nov 5, 2015
Closed
goerz added a commit that referenced this issue Nov 29, 2016
@goerz
Give Feedback I/O ports as kwargs, not operands
9319a44 
Whether the Feedback port numbers are "operands" (which should be
"members of the algebra") is at the very least questionable.
Furthermore, by making out_port and in_port keyword-only arguments, we
make the code more explicit and avoid bugs due to mixing up input and
output. Lastly, renaming the parameters in in preparation for #9
@goerz goerz added QHDL issue should be moved to QHDL package and removed enhancement new or improved features labels May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntezak ntezak

Labels
QHDL issue should be moved to QHDL package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goerz @ntezak