Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on windows #33

Closed
MalteOlle opened this issue Jun 5, 2023 · 5 comments
Closed

Tests fail on windows #33

MalteOlle opened this issue Jun 5, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@MalteOlle
Copy link
Collaborator

MalteOlle commented Jun 5, 2023

Steps to reproduce:

  • Windows 10
  • clone
  • poetry install
  • pip install pomegranate==0.14.2
  • pip install statsmodels
  • poetry run poe test

Result:

FAILED tests/test_data_transforms/test_feature_transformer.py::TestResample::test_resample_roi_list - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_evaluation_utlis/test_parameter_errors.py::TestCalculateAggregatedParameterErrors::test_doctest - assert 3 == 0
FAILED tests/test_zupt_detection/test_moving_window_zupt_detector.py::TestNormZuptDetector::test_single_window_fit[NormZuptDetector] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_moving_window_zupt_detector.py::TestNormZuptDetector::test_single_window_fit[AredZuptDetector] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_moving_window_zupt_detector.py::TestNormZuptDetector::test_max_overlap_metric_max_w4_default_overlap[NormZuptDetector] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_moving_window_zupt_detector.py::TestNormZuptDetector::test_max_overlap_metric_max_w4_default_overlap[AredZuptDetector] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_moving_window_zupt_detector.py::TestNormZuptDetector::test_max_overlap_metric_max_w3[NormZuptDetector] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_moving_window_zupt_detector.py::TestNormZuptDetector::test_max_overlap_metric_max_w3[AredZuptDetector] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_moving_window_zupt_detector.py::TestNormZuptDetector::test_max_overlap_metric_max_w6_default_overlap[NormZuptDetector] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_moving_window_zupt_detector.py::TestNormZuptDetector::test_max_overlap_metric_max_w6_default_overlap[AredZuptDetector] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_moving_window_zupt_detector.py::TestNormZuptDetector::test_real_data_regression[NormZuptDetector] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_moving_window_zupt_detector.py::TestNormZuptDetector::test_real_data_regression[AredZuptDetector] - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_moving_window_zupt_detector.py::TestShoeZuptDetector::test_real_data_regression - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_stride_event_zupt_detector.py::TestStrideEventZuptDetector::test_region_0 - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_stride_event_zupt_detector.py::TestStrideEventZuptDetector::test_edge_case - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_stride_event_zupt_detector.py::TestStrideEventZuptDetector::test_with_overlap - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
FAILED tests/test_zupt_detection/test_stride_event_zupt_detector.py::TestStrideEventZuptDetector::test_simple - AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="start") are different
===================================================================== 17 failed, 2077 passed, 41 skipped, 157 warnings in 577.91s (0:09:37) ======================================================================
@MalteOlle MalteOlle added the bug Something isn't working label Jun 5, 2023
@AKuederle
Copy link
Member

All the tests are unrelated to pomegrante. Strange... these tests are pretty simple. Nothing that should depend on the operating system

@AKuederle
Copy link
Member

@MalteOlle Which Python version are you on?

@AKuederle AKuederle added this to the Public Release milestone Jun 5, 2023
@AKuederle
Copy link
Member

@AKuederle
Copy link
Member

Aah but luckily an easy fix. It has something todo that the default dtype for ints under windows is different. I will try to set the dtype explicit in thee cases. So you can ignore the failures for now.

@AKuederle
Copy link
Member

Fixed! Took some more work than expected, but should work now.
Note that I updated to Pandas >2.0 in the process. You might need to run poetry install again if you want to test the new changes.

I also created a follow-up issue #35, as during fixing that, I realised that we had at least one bug related to "unsafe" type casting from float to int and we should be more explicit about that by not allowing float dtypes in objsects that we expect to be ints. We should force users to perform explicit typecasting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants