-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plot Delay + Stagger unexpected behavior!? (Windows 10) #65
Comments
Which version of plotng are you running? Could you post your config file? |
Something is off... The config file is as I post before. Seems like now the app used both variables times 2h+2h (Stagger + Delay) for a total of 4h delay. It didn't wait for the delay I had set to start the second plot though. I'll change Stagger back to 5 and see if the next plot starts exactly 2h or 2h05min after the last. |
i'm noticing related but different behavior. |
yeah, something is really off with the timers |
Look at those Duration times. The 4th plot (counting up>down) was the only plot in Phase 1 for at least 30 mins while there were only another 3 plots running. This is my config file: But if you notice the 1st and 2nd plot times, you will see that they started much sooner than 2h50min delay of the 5th plot. 2nd plot started 1h50min after 1st. 3rd started only 1h16min after 2nd. 4th started 2h9min after 3rd. The main "issue" here is that phase 1 only had 1 plot for a loooong time while the 5 plots limit was not reached. |
looking at the config you posted above. You can see that you have 2 entries for "PlotSize", which means that this is an invalid configuration. I don't think PlotNG will be able to parse this configuration file properly. Can you check the PlotNG server output to see if there's any error/warning messages? |
Hey! I didn't even noticed the warning from VSC lol. I have removed it now but no, no errors regardless of the 2nd PlotSize option (my guess is that it would replace the 1st entry with the 2nd, which would still be 32 anyways, no?). Anyways, back to the delay issues: My drive became full and it stoped plotting (as expected). I added a new drive 40mins ago, added it in the config, it laded the newly saved config file (as shown below, it recognized the new drive), and it didn't started plotting yet. Config is set to 35-35 for Delay and Stagger still. Idk what might be happening. =/ Edit: |
It seems to me like the combination of a phase 1 check and a delay/stagger are working in a different order than I would expect. And it's more noticeable with long delays. If I have only delay/stagger, and it checks for one hour, it seems to kick off plots every hour
While instead, I would have expected plotng to check every minute, and make sure that each plot was spaced by at least an hour, and that phase1 was enforced, but otherwise, plots would fire every minute. So if I specified a delay of a hour, but phase 1 was full for 1:30, then my next plot would be expected at 1:31. I run staggers of like 3 hours so it's very noticeable. |
That makes a lot of sense. It definitely seems to be working that way. |
Maybe if I explain the logic then this will help (or uncover a bug)
|
Let me think about it. I think your conclusions is very good. As the delays and checks was added over time from user requests so I guess a bit of refactoring is needed. |
Also, just to add to that, when loading a new config the Delay timers should not "reset". For example, if I had a config file with Delay set to 90 mins and I changed my mind and want to set it to 60mins, and the last plot started 70mins ago, just start a new one immediately (because the 60mins delay has already passed since the last plot started) and then set the next one to start after 60mins. My point is, ALWAYS use the last running plot timer as the base do the Delays. Was that clear? Be sure to also make |
okay let's say targetDelayStartTime gets set in the future a few hours away because stagging. |
Phase 1 plots limit wasn't working, but it is working now. The problem is plot timers (delay+stagger) are not working properly. See other comments below. (Updated)
The text was updated successfully, but these errors were encountered: