Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful Exit #75

Open
clmarshall opened this issue Jun 4, 2021 · 3 comments
Open

Graceful Exit #75

clmarshall opened this issue Jun 4, 2021 · 3 comments

Comments

@clmarshall
Copy link

Just a suggestion, feel free to delete if this isn't inline with your thinking.

Premise:

  • Everybody will need to do maintenance sometime.
  • Nobody wants to lose the plots currently in progress.

Suggestion:
A command line option to stop creating new plots at a designated time.

MVP 1 would be just that. A command to prevent new plots from being created while letting in-progess plots continue. When sent it will stop new plots from being created. User waits until all plots are complete, can shutdown safely and resume after maintenance.

MVP 2 could take it a step further and allow scheduling for 1 time, daily, weekly (ex. chron scheme).

To hit a particular point in time it could use avg. plot time + margin of error.

EX: If avg. plot time is 5 hours and scheduled maintenance is 6pm then stop new plotting at 12:30pm for an (arbitrary) 10% margin of error. Ideally the percentage would be just enough to ensure the last plot can complete prior to scheduled time, but 99% of us would probably be happy enough just to be assured all our plots are done prior to maintenance and not worry as much about the 20-30 minutes lost.

@maded2
Copy link
Owner

maded2 commented Jun 4, 2021

So why not just set the NumberOfParallelPlots to zero and let it just cleanly stop.

@clmarshall
Copy link
Author

That's an excellent point. My head was more focused on the scheduling aspect of it, but I could do that now with just a chron to swap out the config file.

@maded2
Copy link
Owner

maded2 commented Jun 4, 2021

can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants