Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting maximum search size #22

Open
ssteiner opened this issue Dec 7, 2020 · 3 comments
Open

Setting maximum search size #22

ssteiner opened this issue Dec 7, 2020 · 3 comments

Comments

@ssteiner
Copy link

ssteiner commented Dec 7, 2020

I recently had a lengthy battle with a domain forest. Apparently, queries on the forest do not support paging. As part of my troubleshooting, I did implement the option to set a maximum search size for when you cannot page. It is another extension method on the configuration. I had to introduce a bunch of variables throughout and expose a protected property to be able to access the property 'SizeLimit' in DirectoryQueryProvider.Execute.

My implementation can be seen here

Any chance you'd consider mainlining that, or maybe you have a better approach.

@rklec
Copy link

rklec commented May 23, 2024

@ssteiner You could create a PR from your fork, so the maintainer can merge it.

@ssteiner
Copy link
Author

I need to learn to cherry pick from the Github UI first, as my fork also drops support for old .NET and that may prevent acceptance of a PR.

@rklec
Copy link

rklec commented Sep 12, 2024

GitHub web UI cannot do this, but apparently the GitHub desktop app can: https://docs.github.com/en/desktop/managing-commits/cherry-picking-a-commit-in-github-desktop Or the git CLI of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants