Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: jumpstart sets must use shared code to generate single boosters #13264

Open
1 of 6 tasks
JayDi85 opened this issue Jan 27, 2025 · 4 comments
Open
1 of 6 tasks
Labels
enhancement refactoring Developers topics about code and programming

Comments

@JayDi85
Copy link
Member

JayDi85 commented Jan 27, 2025

Jumpstart is special booster type of x20 cards. Cards split by themes instead random:
https://mtg.fandom.com/wiki/Jumpstart

Xmage support it by special jumpstart game mode only (see JumpstartPoolGenerator and \resources\jumpstart\jumpstart.txt).

Problems

  1. There are 3 jumpstart sets, but only 1 supported:
    • 2020 - Jumpstart
    • 2022 - Jumpstart 2022
    • 2024 - Foundations Jumpstart
  2. Jumpstart boosters supported by special game mode instead any;
  3. Half decks jumpstart from Ravnica: Clue Edition

What can be done:

  • improved code of JumpstartPoolGenerator to use predefined boosters from all 3 sets instead 1;
  • override createBooster and use shared code from JumpstartPoolGenerator to generate single boosters (see code example from MysteryBooster);
  • so jumpstart boosters can be used in all other game modes after improve;
@JayDi85 JayDi85 added enhancement refactoring Developers topics about code and programming labels Jan 27, 2025
@tiera3
Copy link
Contributor

tiera3 commented Jan 30, 2025

There are also Jumpstart Boosters for BRO, DMU, LTR, MOM, ONE. You might want to consider allowing them to be generated also.

@JayDi85
Copy link
Member Author

JayDi85 commented Jan 30, 2025

Current xmage has limitation by sets structure and GUI: only one booster type per set allowed. It must be reworked someday to support multiple booster types per set.

@JayDi85
Copy link
Member Author

JayDi85 commented Jan 31, 2025

Additional jumpstart style deck and booster: Ravnica: Clue Edition (it used x2 half decks to combine instead x2 full decks like original jumpstart)

@tiera3
Copy link
Contributor

tiera3 commented Feb 2, 2025

All jumpstarts are 2x half decks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement refactoring Developers topics about code and programming
Projects
None yet
Development

No branches or pull requests

2 participants