Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ddsp] Use our own trained model #585

Open
pranayaggarwal opened this issue Aug 24, 2021 · 3 comments
Open

[ddsp] Use our own trained model #585

pranayaggarwal opened this issue Aug 24, 2021 · 3 comments

Comments

@pranayaggarwal
Copy link

pranayaggarwal commented Aug 24, 2021

Hi Team,

We have trained our own ddsp timbre transfer model using these steps

✅ This model is working fine with the notebook version of custom model load i.e. https://colab.research.google.com/github/magenta/ddsp/blob/master/ddsp/colab/demos/timbre_transfer.ipynb

However, we were trying to plug this in magenta-js

We have used following

Could you please help us with this issue and help with fixing perhaps any broken steps, if with current versions?

This is our model.json file https://gist.github.com/pranayaggarwal/fc4503673989ffd48c03e2dec9c9d6e4#file-model-json

Note:

Few things we have noticed while debugging on our own are that -

  1. Existing ddsp models used on https://magenta.github.io/magenta-js/music/demos/ddsp_tone_transfer.html have different structure of model.json where DT_FLOAT of single "size": "80000 is used where our model.json created by ddsp_export.py doesn't have this identical structure and it uses DT_FLOAT of various sizes.

Voilin's model.json https://storage.googleapis.com/magentadata/js/checkpoints/ddsp/violin/model.json

{"format": "graph-model", "generatedBy": "2.4.0", "convertedBy": "TensorFlow.js Converter v1.7.0"

Our model.json by generated by ddps_export has

{"format": "graph-model", "generatedBy": "2.5.0", "convertedBy": "TensorFlow.js Converter v3.8.0"
@pranayaggarwal
Copy link
Author

cc @jesseengel , @notwaldorf

@pranayaggarwal
Copy link
Author

cc @EdwinToh

@jesseengel
Copy link
Collaborator

Sorry for the delay on this. This code path wasn't very robust and probably was broken somewhere along the way. There is some flux with the ddsp repo at the moment (fixing a bug with the power/loudness calculation), so part of fixing that will be making sure this export works. It might take a little bit (hopefully not more than a couple weeks max [sorry, lots of competing priorities]) but it's actively on the TODO list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants