Custom transients cannot take effect

[improve100]

I have added two transients to my emacs configuration file, but their behavior is somewhat strange. The git svn dcommit option works fine, but the git svn rebase option doesn't.

(defun magit-push-to-svn ()
  (interactive)
  (magit-git-command-topdir "git svn dcommit"))
(transient-append-suffix 'magit-push "p"
  '("D" "Push to svn" magit-push-to-svn))

(defun magit-pull-from-svn ()
  (interactive)
  (magit-git-command-topdir "git svn rebase"))
(transient-append-suffix 'magit-pull "F"
  '("R" "Pull from svn" magit-pull-from-svn))

[tarsius]

You've added the command to this group:

  ["Fetch from"
   :if-non-nil magit-pull-or-fetch
   ("f" "remotes"           magit-fetch-all-no-prune)
   ("F" "remotes and prune" magit-fetch-all-prune)]

but then you apparently also (setq magit-pull-or-fetch nil).

(I think git svn rebase is more like rebasing than fetching, so placing that among the fetching commands might not make much sense anyway.)

Instead try placing the command in a new group:

(transient-append-suffix 'magit-pull '(1)
  ["Subversion"
   ("R" "Pull from svn" magit-pull-from-svn)])