Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display danger and critical messages when running update.sh #6272

Open
atomtigerzoo opened this issue Jan 28, 2025 · 5 comments
Open

Display danger and critical messages when running update.sh #6272

atomtigerzoo opened this issue Jan 28, 2025 · 5 comments

Comments

@atomtigerzoo
Copy link

Summary

First: thank you for your time and your efforts running this super cool project!! 🤩

I just updated my instance and did not read the blog before. Shame on me. So I noticed the big upgrades and the removal solr while upgrading. Everything went smooth and I always have automated backups ready, but I had a feeling keeping the process running. After that I went to the blog, to read the update message - and the DANGER! Yeah, I know, shame on me.

But here is my idea:
There is this message when updating, that you have to re-run the updater and sometimes a confirmation y/n. Wouldn't it be super nice, to have these kind of danger or very important messages before starting the update process? Just a "this is a big update - please read the blog before". Not everytime, just in those cases where it would be good to read first. Just in case.

Motivation

  • more information before updating
  • can plan some extra time if something needs manual assistance or just an extra look the logs/htop
  • everyone could read the blog before updating and incoming big changes

Additional context

No response

@DerLinkman
Copy link
Member

Yes that's what i already thought about too. Yeah that should be pretty easily be implemented.

@DerLinkman
Copy link
Member

I'm currently testing with the dialog packages to create such modal boxes:

Image

I can also imagine some sort of this style for a rewrote update.sh in the long run with such "Did you read the changelog ... blabla etc."

@atomtigerzoo
Copy link
Author

Great idea and this looks really cool! But I would keep it simple like the message shown or used right now. Just add a colored (red/pink) warning for updates like the recent one or for breaking changes.

Otherwise it could happen - when this dialog is shown every time (with hints that should be known and followed anyway as a happy sysadmin) - then I (and possibly others too) will just click it away like a cookie banner on third sighting ☺

@DerLinkman
Copy link
Member

Thats there bad then :)

But yes i'll also think about a variant like --non-interactive-mode or something which is not displaying this boxes, except writing it in shell.

@atomtigerzoo
Copy link
Author

Yeah, I know it's my and the others fault, running the update script without visiting the blog first. Not the best attitude sometimes :)
But this is what my tickets intend was: warn only when (really) neccessary. The dialog is really good looking, but I think it will still hide the important information when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants