-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display danger and critical messages when running update.sh #6272
Comments
Yes that's what i already thought about too. Yeah that should be pretty easily be implemented. |
Great idea and this looks really cool! But I would keep it simple like the message shown or used right now. Just add a colored (red/pink) warning for updates like the recent one or for breaking changes. Otherwise it could happen - when this dialog is shown every time (with hints that should be known and followed anyway as a happy sysadmin) - then I (and possibly others too) will just click it away like a cookie banner on third sighting ☺ |
Thats there bad then :) But yes i'll also think about a variant like --non-interactive-mode or something which is not displaying this boxes, except writing it in shell. |
Yeah, I know it's my and the others fault, running the update script without visiting the blog first. Not the best attitude sometimes :) |
Summary
First: thank you for your time and your efforts running this super cool project!! 🤩
I just updated my instance and did not read the blog before. Shame on me. So I noticed the big upgrades and the removal solr while upgrading. Everything went smooth and I always have automated backups ready, but I had a feeling keeping the process running. After that I went to the blog, to read the update message - and the DANGER! Yeah, I know, shame on me.
But here is my idea:
There is this message when updating, that you have to re-run the updater and sometimes a confirmation y/n. Wouldn't it be super nice, to have these kind of danger or very important messages before starting the update process? Just a "this is a big update - please read the blog before". Not everytime, just in those cases where it would be good to read first. Just in case.
Motivation
Additional context
No response
The text was updated successfully, but these errors were encountered: