From ec5b52913040e81bfe1e508c656ca07252054fe5 Mon Sep 17 00:00:00 2001 From: Giuseppe Morelli Date: Wed, 12 Apr 2017 15:48:57 +0200 Subject: [PATCH 1/3] [fix] adminhtml - fix for APPSEC-1034 magento patch --- CHANGELOG.md | 2 ++ .../MailUp/MailUpSync/Model/Observer.php | 4 ++-- .../{ => Mailup}/ConfigurationController.php | 2 +- .../{ => Mailup}/FieldsmappingController.php | 2 +- .../{ => Mailup}/FilterController.php | 2 +- .../Adminhtml/{ => Mailup}/LogController.php | 2 +- .../{ => Mailup}/MailupbackendController.php | 2 +- .../Adminhtml/{ => Mailup}/SyncController.php | 2 +- .../ViewdatatransferlogController.php | 2 +- .../local/MailUp/MailUpSync/etc/config.xml | 24 +++++++++---------- 10 files changed, 23 insertions(+), 21 deletions(-) rename src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/{ => Mailup}/ConfigurationController.php (96%) rename src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/{ => Mailup}/FieldsmappingController.php (90%) rename src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/{ => Mailup}/FilterController.php (99%) rename src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/{ => Mailup}/LogController.php (78%) rename src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/{ => Mailup}/MailupbackendController.php (94%) rename src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/{ => Mailup}/SyncController.php (90%) rename src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/{ => Mailup}/ViewdatatransferlogController.php (80%) diff --git a/CHANGELOG.md b/CHANGELOG.md index d8ba006..7ce4477 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,8 @@ CHANGELOG ========= +- [fix] APPSEC-1034 magento patch + ## 2.7.3 - [fix] SUPEE-6788 | Fix access for non-admin user to config section diff --git a/src/app/code/local/MailUp/MailUpSync/Model/Observer.php b/src/app/code/local/MailUp/MailUpSync/Model/Observer.php index c9ae672..54b719e 100644 --- a/src/app/code/local/MailUp/MailUpSync/Model/Observer.php +++ b/src/app/code/local/MailUp/MailUpSync/Model/Observer.php @@ -334,7 +334,7 @@ public function configCheck() if (!strlen($url_console) or !strlen($user) or !strlen($password) or !strlen($list)) { $url = Mage::getModel('adminhtml/url'); - $url = $url->getUrl("mailup/adminhtml_configuration"); + $url = $url->getUrl("adminhtml/mailup_configuration"); $message = Mage::helper("mailup")->__('MailUp configuration is not complete'); $message = str_replace("href=''", "href='$url'", $message); Mage::getSingleton('adminhtml/session')->addWarning($message); @@ -346,7 +346,7 @@ public function configCheck() $mapping = $wsimport->getFieldsMapping(); if (empty($mapping)) { $url = Mage::getModel('adminhtml/url'); - $url = $url->getUrl("mailup/adminhtml_configuration"); + $url = $url->getUrl("adminhtml/mailup_configuration"); $message = Mage::helper("mailup")->__('MailUp fields mapping is not complete'); $message = str_replace("href=''", "href='$url'", $message); Mage::getSingleton('adminhtml/session')->addWarning($message); diff --git a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/ConfigurationController.php b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/ConfigurationController.php similarity index 96% rename from src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/ConfigurationController.php rename to src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/ConfigurationController.php index db99ebb..73b310a 100644 --- a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/ConfigurationController.php +++ b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/ConfigurationController.php @@ -2,7 +2,7 @@ require_once dirname(__FILE__) . "/../../Model/MailUpWsImport.php"; require_once dirname(__FILE__) . "/../../Model/Wssend.php"; -class MailUp_MailUpSync_Adminhtml_ConfigurationController extends Mage_Adminhtml_Controller_Action +class MailUp_MailUpSync_Adminhtml_Mailup_ConfigurationController extends Mage_Adminhtml_Controller_Action { public function indexAction() { diff --git a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/FieldsmappingController.php b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/FieldsmappingController.php similarity index 90% rename from src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/FieldsmappingController.php rename to src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/FieldsmappingController.php index b099cdc..8190ed3 100644 --- a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/FieldsmappingController.php +++ b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/FieldsmappingController.php @@ -4,7 +4,7 @@ */ require_once dirname(__FILE__) . "/../../Model/MailUpWsImport.php"; require_once dirname(__FILE__) . "/../../Model/Wssend.php"; -class MailUp_MailUpSync_Adminhtml_FieldsMappingController extends Mage_Adminhtml_Controller_Action +class MailUp_MailUpSync_Adminhtml_Mailup_FieldsMappingController extends Mage_Adminhtml_Controller_Action { public function indexAction() { $this->loadLayout()->renderLayout(); diff --git a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/FilterController.php b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/FilterController.php similarity index 99% rename from src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/FilterController.php rename to src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/FilterController.php index 11e9b88..eedfa71 100644 --- a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/FilterController.php +++ b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/FilterController.php @@ -4,7 +4,7 @@ /** * FilterController.php */ -class MailUp_MailUpSync_Adminhtml_FilterController extends Mage_Adminhtml_Controller_Action +class MailUp_MailUpSync_Adminhtml_Mailup_FilterController extends Mage_Adminhtml_Controller_Action { /** * split customers into batches diff --git a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/LogController.php b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/LogController.php similarity index 78% rename from src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/LogController.php rename to src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/LogController.php index fd1df57..0e8322c 100644 --- a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/LogController.php +++ b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/LogController.php @@ -2,7 +2,7 @@ /** * LogController.php */ -class MailUp_MailUpSync_Adminhtml_LogController extends Mage_Adminhtml_Controller_Action +class MailUp_MailUpSync_Adminhtml_Mailup_LogController extends Mage_Adminhtml_Controller_Action { /** * Default Action diff --git a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/MailupbackendController.php b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/MailupbackendController.php similarity index 94% rename from src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/MailupbackendController.php rename to src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/MailupbackendController.php index 7413c2a..f4e1879 100644 --- a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/MailupbackendController.php +++ b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/MailupbackendController.php @@ -1,5 +1,5 @@ loadLayout()->renderLayout(); diff --git a/src/app/code/local/MailUp/MailUpSync/etc/config.xml b/src/app/code/local/MailUp/MailUpSync/etc/config.xml index 48436ad..d251ce3 100644 --- a/src/app/code/local/MailUp/MailUpSync/etc/config.xml +++ b/src/app/code/local/MailUp/MailUpSync/etc/config.xml @@ -182,13 +182,13 @@ - - admin - - MailUp_MailUpSync - mailup - - + + + + MailUp_MailUpSync_Adminhtml + + + @@ -243,28 +243,28 @@ <![CDATA[Settings & Field Mapping]]> - mailup/adminhtml_configuration + adminhtml/mailup_configuration 0 Filters - mailup/adminhtml_filter + adminhtml/mailup_filter 10 View MailUp Tasks 20 - mailup/adminhtml_mailupbackend + adminhtml/mailup_mailupbackend View Task Data 30 - mailup/adminhtml_sync + adminhtml/mailup_sync View Logs 40 - mailup/adminhtml_log + adminhtml/mailup_log From 8128a95e0c954743c52806e210b344f0ac37ae1e Mon Sep 17 00:00:00 2001 From: Giuseppe Morelli Date: Fri, 14 Apr 2017 13:02:46 +0200 Subject: [PATCH 2/3] [fix] adminhtml - fix include Model path --- .../controllers/Adminhtml/Mailup/ConfigurationController.php | 4 ++-- .../controllers/Adminhtml/Mailup/FieldsmappingController.php | 4 ++-- .../controllers/Adminhtml/Mailup/FilterController.php | 4 ++-- .../Adminhtml/Mailup/ViewdatatransferlogController.php | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/ConfigurationController.php b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/ConfigurationController.php index 73b310a..ce7ddbc 100644 --- a/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/ConfigurationController.php +++ b/src/app/code/local/MailUp/MailUpSync/controllers/Adminhtml/Mailup/ConfigurationController.php @@ -1,7 +1,7 @@ Date: Fri, 21 Apr 2017 09:11:41 +0200 Subject: [PATCH 3/3] [dev] release 2.7.4 - changelog - readme --- CHANGELOG.md | 1 + README.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7ce4477..a0fb829 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ CHANGELOG ========= +## 2.7.4 - [fix] APPSEC-1034 magento patch ## 2.7.3 diff --git a/README.md b/README.md index 7f996c5..3da31f3 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ MailUp is your complete email delivery solution. It combines strong campaign man We are working for a brand new extension. Thank you for your patience. ## Stable version -2.7.3 +2.7.4 ## Magento version