Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http://pre-commit.ci/ #3741

Open
3 tasks done
mathbunnyru opened this issue Jan 13, 2025 · 2 comments
Open
3 tasks done

Add http://pre-commit.ci/ #3741

mathbunnyru opened this issue Jan 13, 2025 · 2 comments

Comments

@mathbunnyru
Copy link
Contributor

Troubleshooting docs

  • My problem is not solved in the Troubleshooting docs

Anaconda default channels

  • I do NOT use the Anaconda default channels (pkgs/* etc.)

How did you install Mamba?

Other (please describe)

Search tried in issue tracker

pre-commit

Latest version of Mamba

  • My problem is not solved with the latest version

Tried in Conda?

Not applicable

Describe your issue

I recommend adding https://pre-commit.ci/ as an app:

  • it runs faster
  • applies autofixes in PRs (when tools have autofixes).
  • you can auto-update hooks, which is quite nice

We've been using it for years across several jupyter projects - it works really well.
I won't be able to add this tool myself - you need org-level permissions to do that.

It requires almost zero configuration and reuses .pre-commit-config.yaml.

mamba info / micromamba info

No response

Logs

No response

environment.yml

No response

~/.condarc

No response

@mathbunnyru
Copy link
Contributor Author

@jjerphan I made a bunch of changes on how we use pre-commit hooks, please, take a look.

I think after that I will be done with this type of changes and they will be set-up nicely in this repo with autoupdates, almost all files will be formatted and so on.

@jjerphan
Copy link
Member

Thank you for your suggestions, @mathbunnyru.

We might have a look at it later but for now that's not a priority for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants