Add try-catch to VM-Pip-Install #1258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sara-rn
force-pushed
the
git-pip-install-try-catc
branch
3 times, most recently
from
16e9df4 to
f2e3b1c
Compare
Ana06
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Thanks for working on this @sara-rn.
[nitpick] The commit message is a bit confusing and it does not explain why the change is needed. I propose to improve it as follows:
Add try-catch to VM-Pip-Install
Add missing `try-catch` to `VM-Pip-Install` so that packages using this
function (such as ida.plugin.hashdb.vm) don't have to add a try-catch.
| ForEach ($library in $libraries.Split(",")) { | ||
| # Ignore warning with `-W ignore` to avoid warnings like deprecation to fail the installation | ||
| Invoke-Expression "py -3.10 -W ignore -m pip install $library --disable-pip-version-check 2>&1 >> $outputFile" | ||
| try{ |
There was a problem hiding this comment.
[nitpick]
Suggested change
| try{ | |
| try { |
| } | ||
| Install-ChocolateyZipPackage @packageArgs |
There was a problem hiding this comment.
you can't remove the try-catch in packages/ida.plugin.capa.vm/tools/chocolateyinstall.ps1 as the installation of the rules does not use the helper function and that could fail too.
sara-rn
force-pushed
the
git-pip-install-try-catc
branch
3 times, most recently
from
2da03d2 to
fcd2527
Compare
Add missing `try-catch` to `VM-Pip-Install` so that packages using this function (such as ida.plugin.hashdb.vm) don't have to add a try-catch.
sara-rn
force-pushed
the
git-pip-install-try-catc
branch
from
fcd2527 to
8c481fa
Compare
|
@Ana06 changes have been addressed, thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove try-catch from install scripts that use VM-Pip-Install
Closes #1205